Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] Cherrypick #406 #408

Merged
merged 1 commit into from
Nov 10, 2018
Merged

[release-1.12] Cherrypick #406 #408

merged 1 commit into from
Nov 10, 2018

Conversation

Random-Liu
Copy link
Contributor

For #403.

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot requested a review from runcom November 9, 2018 18:59
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2018
@Random-Liu Random-Liu added cherrypick and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2018
@Random-Liu Random-Liu changed the title Use metadata to filter instead of using labels. [release-1.12] Cherrypick #403 Nov 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2018
@Random-Liu Random-Liu changed the title [release-1.12] Cherrypick #403 [release-1.12] Cherrypick #406 Nov 9, 2018
@Random-Liu Random-Liu force-pushed the cherrypick-#406-release-1.12 branch from 5d3294d to e3dcb80 Compare November 9, 2018 19:44
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2018
feiskyer
feiskyer reviewed Nov 10, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 43f5e6e into kubernetes-sigs:release-1.12 Nov 10, 2018
@Random-Liu Random-Liu deleted the cherrypick-#406-release-1.12 branch November 13, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@runcom runcom Awaiting requested review from runcom

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherrypick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Random-Liu @k8s-ci-robot @feiskyer