Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow nested maps only when used with 'AllowDangerousTypes' flag. #569

Closed
wants to merge 1 commit into from
Closed

✨ Allow nested maps only when used with 'AllowDangerousTypes' flag. #569

wants to merge 1 commit into from

Conversation

vijtrip2
Copy link

@vijtrip2 vijtrip2 commented May 6, 2021

Adding nested maps to the dangerous-types and allowing nested maps only when 'allowDangerousTypes' flag is passed.

There is already a PR open for this change, Please see that for previous discussion . See #518 (Credits to @Porges )

This change will help in unblocking following two use cases and possibly more:

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @vijtrip2!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from mengqiy and pwittrock May 6, 2021 22:29
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2021
@vijtrip2
Copy link
Author

vijtrip2 commented May 6, 2021

re-run cla/linuxfoundation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 6, 2021
This was referenced May 6, 2021
Merged
Closed
@vijtrip2 vijtrip2 force-pushed the allow-nested-maps branch from 404e1c6 to 5d934cd Compare May 7, 2021 16:41
@mengqiy mengqiy requested review from kevindelgado and DirectXMan12 and removed request for mengqiy May 13, 2021 21:38
@matthchr matthchr mentioned this pull request May 18, 2021
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2021
@vijtrip2
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2021
kevindelgado
kevindelgado reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@kevindelgado kevindelgado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, but mostly LGTM from me.

I don't have approval powers (nor the final say on whether we actually do want to allow nested maps behind the dangerous types flag).

Leaving it to @vincepri, who I think is the sole remaining approver.

pkg/crd/testdata/dangerous_types/dangerous.example.com_dangeroustypes.yaml Outdated Show resolved Hide resolved
pkg/crd/parser_integration_test.go Outdated Show resolved Hide resolved
@kevindelgado
Copy link
Contributor

/assign @vincepri

@kevindelgado
Copy link
Contributor

cc @munnerz in case you have any thoughts since you commented on the original PR #518

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vijtrip2
To complete the pull request process, please ask for approval from vincepri after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijtrip2 vijtrip2 mentioned this pull request Aug 17, 2021
Merged
ack-bot pushed a commit to aws-controllers-k8s/apigatewayv2-controller that referenced this pull request Aug 18, 2021
@vijtrip2
Upgrade apigatewayv2 controller to ack runtime v0.12.0 (#7)
b57b67e 
Issue aws-controllers-k8s/community#894

* Regenrate apigatewayv2 controller with runtime v0.12.0 & aws-sdk-go v1.35.5. ( aws-sdk-go upgrade is blocked due to kubernetes-sigs/controller-tools#569 )
* Made sure multiple Apis are not created during reconciliation
* Removed the support for 'APIKeySelectionExpression' field in custom update call because API Gateway team added new validation that this field should not be used.
* Fixed the e2e tests and made sure they can execute successfully independent in parallel threads.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Porges
Copy link
Contributor

Porges commented Sep 16, 2021

Can be closed since #518 was merged.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

@vijtrip2: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vijtrip2 vijtrip2 closed this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindelgado kevindelgado kevindelgado left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@vincepri vincepri

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vijtrip2 @k8s-ci-robot @k8s-triage-robot @kevindelgado @Porges @vincepri