Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller-gen doesn't support deeply nested maps #1489

Closed
matthchr opened this issue May 18, 2021 · 3 comments
Closed

controller-gen doesn't support deeply nested maps #1489

matthchr opened this issue May 18, 2021 · 3 comments

Comments

@matthchr
Copy link
Member

This comes up for example here:
microsoft.machinelearning/v20170101/ExampleRequest the Inputs field which has the type map[string][][]map[string]v1.JSON (after the pipeline stage that replaces AnyTypes).

@matthchr matthchr added the task label May 18, 2021
@matthchr matthchr added this to the codegen-beta milestone May 18, 2021
@matthchr
Copy link
Member Author

There's a PR out to support this here, which I think is based on @Porges PR here

@Porges
Copy link
Member

Porges commented Sep 16, 2021

My PR probably won’t fix this particular case: maps containing arrays are currently only allowed to have arrays of strings, which is a different restriction to the one that I am lifting. (See: kubernetes-sigs/controller-tools#518 (comment).) However, this will be an easy restriction to lift.

@Porges
Copy link
Member

Porges commented Sep 20, 2021

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants