Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow maps of arrays of non-string types #617

Merged
merged 3 commits into from
Sep 20, 2021
Merged

✨ Allow maps of arrays of non-string types #617

merged 3 commits into from
Sep 20, 2021

Conversation

Porges
Copy link
Contributor

@Porges Porges commented Sep 16, 2021 •
edited
Loading

Lifts the restriction currently imposed on map value types (that if they are arrays they must be arrays of strings), per #518 (comment). We have encountered this while trying to use controller-gen (Azure/azure-service-operator#1489).

Also add a way to add simple schema-transform tests, rather than by adding items to cronjob_types.go (where the output is validated by inspection).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Porges. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2021
Porges
Porges commented Sep 16, 2021
View reviewed changes
pkg/schemapatcher/zz_generated.markerhelp.go Outdated
@@ -40,6 +40,10 @@ func (Generator) Help() *markers.DefinitionHelp {
Summary: "specifies the maximum description length for fields in CRD's OpenAPI schema. ",
Details: "0 indicates drop the description for all fields completely. n indicates limit the description to at most n characters and truncate the description to closest sentence boundary if it exceeds n characters.",
},
"GenerateEmbeddedObjectMeta": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appeared: it should probably already have been checked in.

@Porges
Copy link
Contributor Author

Porges commented Sep 16, 2021

@alvaroaleman please take a look, this is a follow-on to the last PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, Porges

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@alvaroaleman
Copy link
Member

/lgtm cancel
floats are generally not allowed, ref #245

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@Porges
Copy link
Contributor Author

Porges commented Sep 19, 2021

@alvaroaleman floats are generally not allowed, ref #245

Corrected golden file test.

@alvaroaleman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2021
@alvaroaleman
Copy link
Member

/label tide/merge-method-squash
@Porges Can you fix the compile error please?

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 19, 2021
@Porges
Copy link
Contributor Author

Porges commented Sep 19, 2021

@alvaroaleman looks like a bad linter, have updated code to fix.

@Porges Porges force-pushed the allow-maps-to-contain-all-slice-types branch from e1a7c2d to 61ad765 Compare September 19, 2021 22:18
@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit d9ac9f3 into kubernetes-sigs:master Sep 20, 2021
@Porges Porges deleted the allow-maps-to-contain-all-slice-types branch September 20, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Porges @k8s-ci-robot @alvaroaleman