Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade apigatewayv2 controller to ack runtime v0.12.0 #7

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Upgrade apigatewayv2 controller to ack runtime v0.12.0 #7

merged 1 commit into from
Aug 18, 2021

Conversation

vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Aug 17, 2021 •
edited
Loading

Issue aws-controllers-k8s/community#894

  • Regenrate apigatewayv2 controller with runtime v0.12.0 & aws-sdk-go v1.35.5. ( aws-sdk-go upgrade is blocked due to ✨ Allow nested maps only when used with 'AllowDangerousTypes' flag. kubernetes-sigs/controller-tools#569 )
  • Made sure multiple Apis are not created during reconciliation
  • Removed the support for 'APIKeySelectionExpression' field in custom update call because API Gateway team added new validation that this field should not be used.
  • Fixed the e2e tests and made sure they can execute successfully independent in parallel threads.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vijtrip2
Copy link
Contributor Author

/ok-to-test

@vijtrip2
Copy link
Contributor Author

/test apigatewayv2-kind-e2e

@vijtrip2
Copy link
Contributor Author

/test apigatewayv2-release-test

@vijtrip2
Copy link
Contributor Author

/retest

@vijtrip2 vijtrip2 changed the title Upgrade apigatewayv2 controller to ack runtime v0.11.0 Upgrade apigatewayv2 controller to ack runtime v0.12.0 Aug 18, 2021
jaypipes
jaypipes approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit b57b67e into aws-controllers-k8s:main Aug 18, 2021
@vijtrip2 vijtrip2 deleted the runtime-v0.11.0 branch August 18, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@jaypipes jaypipes

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijtrip2 @jaypipes @ack-bot