🌱 Add Machinepool conversion #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
sbueringer
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-add-machinepool-conversion
branch
from
e25a6ca to
d4dec1c
Compare
k8s-ci-robot
added
the
needs-rebase
sbueringer
force-pushed
the
pr-add-machinepool-conversion
branch
from
d4dec1c to
2bf89ac
Compare
k8s-ci-robot
added
size/L
sbueringer
commented
Sep 21, 2021
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-add-machinepool-conversion
branch
from
2bf89ac to
6deb9f6
Compare
|
/assign @vincepri |
sbueringer
force-pushed
the
pr-add-machinepool-conversion
branch
from
6deb9f6 to
a3efe9d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
vincepri
reviewed
Sep 22, 2021
Signed-off-by: Stefan Bueringer <[email protected]>
sbueringer
force-pushed
the
pr-add-machinepool-conversion
branch
from
a3efe9d to
b276512
Compare
k8s-ci-robot
removed
the
lgtm
|
@vincepri should be fixed, ptal |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds MachinePool conversion.
WIP until #5248 has been merged
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5265