Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Prepare for v1beta1 #5248

Merged
merged 14 commits into from
Sep 20, 2021
Merged

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2021
@vincepri
Copy link
Member Author

/milestone v1.0
/kind release-blocking

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label Sep 16, 2021
@vincepri vincepri force-pushed the v1beta1 branch 3 times, most recently from 1bb9a31 to 868e086 Compare September 16, 2021 05:24
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 1 😄

api/v1alpha3/conversion.go Outdated Show resolved Hide resolved
api/v1alpha3/conversion_test.go Outdated Show resolved Hide resolved
api/v1alpha4/groupversion_info.go Show resolved Hide resolved
@vincepri vincepri force-pushed the v1beta1 branch 4 times, most recently from 0309af7 to c236d52 Compare September 16, 2021 16:03
@vincepri vincepri changed the title WIP: ⚠️ Prepare for v1beta1 ⚠️ Prepare for v1beta1 Sep 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2021
@vincepri vincepri force-pushed the v1beta1 branch 10 times, most recently from afb3d64 to 7e96300 Compare September 16, 2021 18:05
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
vincepri and others added 12 commits September 20, 2021 11:52
Signed-off-by: Vince Prignano <[email protected]>
Co-authored-by: ykakarap <[email protected]>
Having the same package names was causing conflicts in the conversion
generation code, for example InitConfiguration is in both CABPK's code
and upstream types.

Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@ykakarap
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

@vincepri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main fc52fe3 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

/lgtm

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit b8ad4e4 into kubernetes-sigs:master Sep 20, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.0, v0.4 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants