Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion for MachinePool #5265

Closed
sbueringer opened this issue Sep 20, 2021 · 6 comments · Fixed by #5267
Closed

Add conversion for MachinePool #5265

sbueringer opened this issue Sep 20, 2021 · 6 comments · Fixed by #5267
Assignees
@sbueringer
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Milestone
v1.0

Comments

@sbueringer
Copy link
Member

sbueringer commented Sep 20, 2021 •
edited
Loading

Let's add the following for MachinePools (after #5248)

  • conversion.go in v1alpha4 package
  • conversion fuzzy test
  • webhook conversion patches in config/

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2021
@sbueringer
Copy link
Member Author

/assign

This was referenced Sep 20, 2021
Merged
Merged
@killianmuldoon
Copy link
Contributor

Is this actually related to #4853 somehow? I don't understand the direct connection

@CecileRobertMichon
Copy link
Contributor

should be after #5248

@vincepri
Copy link
Member

/milestone v1.0

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Sep 20, 2021
@sbueringer
Copy link
Member Author

should be after #5248

+1, I fixed the description

@fabriziopandini
Copy link
Member

/kind release-blocking

@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label Sep 21, 2021
@killianmuldoon killianmuldoon mentioned this issue Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbueringer sbueringer

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

🌱 Add Machinepool conversion sbueringer/cluster-api
6 participants
@vincepri @sbueringer @fabriziopandini @CecileRobertMichon @k8s-ci-robot @killianmuldoon