Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 feat: add EKS controlplane provider #3685

Merged
merged 1 commit into from
Oct 1, 2020
Merged

🌱 feat: add EKS controlplane provider #3685

merged 1 commit into from
Oct 1, 2020

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Sep 23, 2020 •
edited
Loading

What this PR does / why we need it:
This adds the eks control plane provider to clusterctl. This is to enable users to install the provider using clusterctl init. The EKS Control Plane has been split into its own provider and will be avaiyable in the 0.6.1 release of CAPA.

Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cluster-api-provider-aws#1970

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2020
@vincepri
Copy link
Member

/retest

@vincepri
Copy link
Member

@richardcase Are you still interested in getting this change in v0.3.10?

@richardcase
Copy link
Member Author

@vincepri - yes would love to, can't look at fixing the tests until tomorrow though

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2020
@richardcase
Copy link
Member Author

/test pull-cluster-api-test

@fabriziopandini
Copy link
Member

/approve
@richardcase please squash commits

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@fabriziopandini
Copy link
Member

/hold
due to code freeze

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@richardcase
Copy link
Member Author

please squash commits

@fabriziopandini - commits squashed and pushed.

@vincepri
Copy link
Member

vincepri commented Oct 1, 2020

/hold cancel
/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Oct 1, 2020
@fabriziopandini
Copy link
Member

/approve cancel

@fabriziopandini
Copy link
Member

/lgtm
lgtm before approval according to https://github.com/kubernetes-sigs/cluster-api/blob/master/CONTRIBUTING.md#approvals

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@richardcase
feat: add EKS controlplane provider
688d6d7 
Add the EKS control plane provider to `clusterctl` which will be
available in the **0.6.1** release of CAPA.

The EKS bootstrap and control plane providers have had their names
changes so they are prefixed with aws and both end up being
`aws-eks`.

The apidiff test fails will fail with this changed due to the removal
of the  `EKSBootstrapProviderName` provider name.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

@richardcase: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-verify-external-links e6e0d82 link /test pull-cluster-api-verify-external-links
pull-cluster-api-apidiff 688d6d7 link /test pull-cluster-api-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

vincepri commented Oct 1, 2020

/assign @randomvariable @wfernandes
for final LGTM,

Waiting for tests to pass before approving

@vincepri
Copy link
Member

vincepri commented Oct 1, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit af66309 into kubernetes-sigs:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@mytunguyen mytunguyen Awaiting requested review from mytunguyen

@rudoi rudoi Awaiting requested review from rudoi

Assignees

@randomvariable randomvariable

@wfernandes wfernandes

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.10
Development

Successfully merging this pull request may close these issues.

Add EKS Control Plane Provider to clusterctl
7 participants
@richardcase @vincepri @fabriziopandini @k8s-ci-robot @randomvariable @rudoi @wfernandes