Skip to content

Commit

Permalink
refactor: changed the name of the eks providers
Browse files Browse the repository at this point in the history
The EKS bootstrap and control plane providers have had their names
changes so they are prefixed with aws and both end up being
`aws-eks`.
  • Loading branch information
richardcase committed Sep 23, 2020
1 parent 8c75e4a commit e6e0d82
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions cmd/clusterctl/client/config/providers_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ const (
// Bootstrap providers
KubeadmBootstrapProviderName = "kubeadm"
TalosBootstrapProviderName = "talos"
EKSBootstrapProviderName = "eks"
AWSEKSBootstrapProviderName = "aws-eks"

// ControlPlane providers
KubeadmControlPlaneProviderName = "kubeadm"
TalosControlPlaneProviderName = "talos"
EKSControlPlaneProviderName = "eks"
AWSEKSControlPlaneProviderName = "aws-eks"

// Other
ProvidersConfigKey = "providers"
Expand Down Expand Up @@ -155,7 +155,7 @@ func (p *providersClient) defaults() []Provider {
providerType: clusterctlv1.BootstrapProviderType,
},
&provider{
name: EKSBootstrapProviderName,
name: AWSEKSBootstrapProviderName,
url: "https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/eks-bootstrap-components.yaml",
providerType: clusterctlv1.BootstrapProviderType,
},
Expand All @@ -171,7 +171,7 @@ func (p *providersClient) defaults() []Provider {
providerType: clusterctlv1.ControlPlaneProviderType,
},
&provider{
name: EKSControlPlaneProviderName,
name: AWSEKSControlPlaneProviderName,
url: "https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/eks-controlplane-components.yaml",
providerType: clusterctlv1.ControlPlaneProviderType,
},
Expand Down
8 changes: 4 additions & 4 deletions cmd/clusterctl/client/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
// note: these will be sorted by name by the Providers() call, so be sure they are in alphabetical order here too
wantProviders: []string{
config.ClusterAPIProviderName,
config.EKSBootstrapProviderName,
config.AWSEKSBootstrapProviderName,
config.KubeadmBootstrapProviderName,
config.TalosBootstrapProviderName,
config.KubeadmControlPlaneProviderName,
config.TalosControlPlaneProviderName,
config.EKSControlPlaneProviderName,
config.AWSEKSControlPlaneProviderName,
config.AWSProviderName,
config.AzureProviderName,
config.DOProviderName,
Expand All @@ -82,12 +82,12 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
wantProviders: []string{
config.ClusterAPIProviderName,
customProviderConfig.Name(),
config.EKSBootstrapProviderName,
config.AWSEKSBootstrapProviderName,
config.KubeadmBootstrapProviderName,
config.TalosBootstrapProviderName,
config.KubeadmControlPlaneProviderName,
config.TalosControlPlaneProviderName,
config.EKSControlPlaneProviderName,
config.AWSEKSControlPlaneProviderName,
config.AWSProviderName,
config.AzureProviderName,
config.DOProviderName,
Expand Down
4 changes: 2 additions & 2 deletions cmd/clusterctl/client/repository/metadata_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func (f *metadataClient) getEmbeddedMetadata() *clusterctlv1.Metadata {
// older version are not supported by clusterctl
},
}
case config.EKSBootstrapProviderName:
case config.AWSEKSBootstrapProviderName:
return &clusterctlv1.Metadata{
TypeMeta: metav1.TypeMeta{
APIVersion: clusterctlv1.GroupVersion.String(),
Expand Down Expand Up @@ -196,7 +196,7 @@ func (f *metadataClient) getEmbeddedMetadata() *clusterctlv1.Metadata {
// there are no older version for Talos controlplane
},
}
case config.EKSControlPlaneProviderName:
case config.AWSEKSControlPlaneProviderName:
return &clusterctlv1.Metadata{
TypeMeta: metav1.TypeMeta{
APIVersion: clusterctlv1.GroupVersion.String(),
Expand Down

0 comments on commit e6e0d82

Please sign in to comment.