chore: re-instating eks boostrap provider

The apidiff test fails if anything is changed `EKSBootstrapProviderName`
so this has been kept. The new provider `AWSEKSBootstrapProviderName`
will be used instead in documentation and the providers list. If anyone
uses the `EKSBootstrapProviderName` then it will return the same as the
`AWSEKSBootstrapProviderName`.

cmd/clusterctl/client/config/providers_client.go

@@ -44,7 +44,8 @@ const (
 	// Bootstrap providers
 	KubeadmBootstrapProviderName = "kubeadm"
 	TalosBootstrapProviderName   = "talos"
-	EKSBootstrapProviderName     = "aws-eks"
+	EKSBootstrapProviderName     = "eks" // DEPRECATED: if this provider is used it returns the same as aws-eks
+	AWSEKSBootstrapProviderName  = "aws-eks"
 
 	// ControlPlane providers
 	KubeadmControlPlaneProviderName = "kubeadm"
@@ -155,7 +156,7 @@ func (p *providersClient) defaults() []Provider {
 			providerType: clusterctlv1.BootstrapProviderType,
 		},
 		&provider{
-			name:         EKSBootstrapProviderName,
+			name:         AWSEKSBootstrapProviderName,
 			url:          "https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/eks-bootstrap-components.yaml",
 			providerType: clusterctlv1.BootstrapProviderType,
 		},

cmd/clusterctl/client/config_test.go

@@ -55,7 +55,7 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
 			// note: these will be sorted by name by the Providers() call, so be sure they are in alphabetical order here too
 			wantProviders: []string{
 				config.ClusterAPIProviderName,
-				config.EKSBootstrapProviderName,
+				config.AWSEKSBootstrapProviderName,
 				config.KubeadmBootstrapProviderName,
 				config.TalosBootstrapProviderName,
 				config.AWSEKSControlPlaneProviderName,
@@ -81,7 +81,7 @@ func Test_clusterctlClient_GetProvidersConfig(t *testing.T) {
 			// note: these will be sorted by name by the Providers() call, so be sure they are in alphabetical order here too
 			wantProviders: []string{
 				config.ClusterAPIProviderName,
-				config.EKSBootstrapProviderName,
+				config.AWSEKSBootstrapProviderName,
 				customProviderConfig.Name(),
 				config.KubeadmBootstrapProviderName,
 				config.TalosBootstrapProviderName,

cmd/clusterctl/client/repository/metadata_client.go

@@ -156,7 +156,7 @@ func (f *metadataClient) getEmbeddedMetadata() *clusterctlv1.Metadata {
 					// older version are not supported by clusterctl
 				},
 			}
-		case config.EKSBootstrapProviderName:
+		case config.EKSBootstrapProviderName, config.AWSEKSBootstrapProviderName:
 			return &clusterctlv1.Metadata{
 				TypeMeta: metav1.TypeMeta{
 					APIVersion: clusterctlv1.GroupVersion.String(),