Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨clusterctl: allow cert-manager image overrides #2558

Merged
merged 1 commit into from
Mar 6, 2020
Merged

✨clusterctl: allow cert-manager image overrides #2558

merged 1 commit into from
Mar 6, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
The cert-manager manifest is embedded in clusterctl so it cannot be easily changed like e.g. provider manifests. This PR adds configurations to allow to set imageRepository/ImageTag (similar to ImageMeta for etcd/CoreDns in kubeadm)

Which issue(s) this PR fixes:
Fixes #2555

/area clusterctl
/assing @vincepri @ncdc

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2020
@fabriziopandini fabriziopandini force-pushed the clusterctl-cert-manager-image-overrides branch from c696e90 to 3c9e97b Compare March 6, 2020 08:50
@fabriziopandini
Copy link
Member Author

@neolit123 thanks for your review! comment addressed

@fabriziopandini
Copy link
Member Author

/assign @ncdc

@fabriziopandini fabriziopandini mentioned this pull request Mar 6, 2020
Closed
@neolit123
Copy link
Member

LGTM

@neolit123 neolit123 mentioned this pull request Mar 6, 2020
Merged
@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2020

Starting my full review now

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Mar 6, 2020 •
edited
Loading

@ncdc sorry, I noticed you were reviewing only after push the requested change on for using github.com/docker/distribution/reference 😅

@fabriziopandini
Copy link
Member Author

@ncdc comment addressed
(there is still issue on go modules, investigating)

@vincepri
Copy link
Member

vincepri commented Mar 6, 2020

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 6, 2020
@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2020

/lgtm
@vincepri or @wfernandes - want to 👀 ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@vincepri
Copy link
Member

vincepri commented Mar 6, 2020

👍 in the middle of review

@randomvariable
Copy link
Member

@fabriziopandini need to rebase in light of #2552, sorry!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2020
@fabriziopandini fabriziopandini force-pushed the clusterctl-cert-manager-image-overrides branch from f7746bf to f07371d Compare March 6, 2020 20:14
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 6, 2020
@fabriziopandini
Copy link
Member Author

@randomvariable no problem!
rebased

vincepri
vincepri approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit b51a61e into kubernetes-sigs:master Mar 6, 2020
@fabriziopandini fabriziopandini deleted the clusterctl-cert-manager-image-overrides branch March 7, 2020 12:15
This was referenced Mar 9, 2020
Merged
Merged
@Mangga-web
Copy link

可以帮我安装这软件吗。我不会安装。。不好意思

@fabriziopandini fabriziopandini mentioned this pull request Mar 11, 2020
Closed
@fabriziopandini fabriziopandini mentioned this pull request Mar 29, 2020
Closed
@Xenwar Xenwar mentioned this pull request Jun 24, 2020
Closed
@sirajyasin sirajyasin mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@neolit123 neolit123 neolit123 left review comments

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@ncdc ncdc

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

clusterctl: Allow set ImageRepository and ImageTag for certmanager
9 participants
@fabriziopandini @fejta-bot @neolit123 @ncdc @vincepri @randomvariable @k8s-ci-robot @Mangga-web @detiber