Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert-manager functions hardcoded, Not using manifests/global/functions. #350

Closed
sb464f opened this issue Sep 15, 2020 · 9 comments
Closed

cert-manager functions hardcoded, Not using manifests/global/functions. #350

sb464f opened this issue Sep 15, 2020 · 9 comments
Assignees
@sirajyasin
Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Milestone
v2.0

Comments

@sb464f
Copy link
Contributor

sb464f commented Sep 15, 2020

Looks like clusterctl is hardcoded with cert-manager values and thus airshipctl which is using clusterctl getting hard coded values of cert-manager pods/images.

Steps to Reproduce
deploy ephemeral node by overriding image values of cert-manager functions in /manifests/global/functions/cert-manager but those values will not be effective it will still have hardcoded images

Expected behavior
manifests/global/functions/cert-manager to be effective
@sb464f sb464f added bug Something isn't working triage Needs evaluation by project members labels Sep 15, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Sep 30, 2020
@jezogwza jezogwza added this to the v2.0 milestone Sep 30, 2020
@sirajyasin
Copy link
Contributor

I can work on this issue if no one has started yet.

@sreejithpunnapuzha
Copy link
Member

@sirajyasin all yours

@jezogwza jezogwza added the priority/critical Items critical to be implemented, usually by the next release label Oct 7, 2020
@airshipbot
Copy link

airshipbot commented Oct 8, 2020 •
edited
Loading

Related Change #756606

Subject: Use global certmanager for clusterctl
Link: https://review.opendev.org/756606
Status: MERGED
Owner: Sirajudeen ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
+1 Stas Egorov
+2 Kostyantyn Kalynovskyi
+1 srinivasa muly
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-10-27 18:00:04 CDT

@airshipbot airshipbot added the wip Work in progress label Oct 8, 2020
@sirajyasin
Copy link
Contributor

@sb464f , in airshipctl the images are not hardcoded and it is configurable through the variables.

https://review.opendev.org/gitweb?p=airship/airshipctl.git;a=blob;f=manifests/function/clusterctl/clusterctl.yaml;h=7380053a34ba4831dae3db319073981c4540d158;hb=refs/heads/master#l37

Please let us know if this solves your concern

@sb464f
Copy link
Contributor Author

sb464f commented Oct 8, 2020

@sirajyasin I am looking for jestatck cert-manager images. they seem to be hardcoded in clusterctl.

@sirajyasin
Copy link
Contributor

Thanks @sb464f . There is an issue for this upstream and looks like it is fixed and available in v0.3.10
kubernetes-sigs/cluster-api#2558

With our recent uplift of cluster-api (https://review.opendev.org/#/c/756134/), the image override should be working. I will test and push a PS for the same

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed wip Work in progress labels Oct 13, 2020
@airshipbot
Copy link

airshipbot commented Oct 14, 2020 •
edited
Loading

Related Change #757987

Subject: Image override for cert-manager components
Link: https://review.opendev.org/757987
Status: NEW
Owner: Sirajudeen ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
+2 Matt McEuen
Verified
+1 Zuul
Workflow
! None

Last Updated: 2020-11-10 20:15:11 CST

@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot removed the ready for review Change related to the issue is ready for review label Oct 27, 2020
@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Oct 27, 2020
@airshipbot
Copy link

The Change that closes this issue was merged.

@airshipbot airshipbot removed the ready for review Change related to the issue is ready for review label Nov 12, 2020
airshipbot pushed a commit that referenced this issue Nov 12, 2020
@sirajyasin @teoyaomiqui
Image override for cert-manager components
b266e18 
* Images added to clusterctl object like Providers
  So that repository and tag for one or all of the cert-manager
  components can be overriden using patch/replacement

clusterctl Documentation for Image Override:
  https://cluster-api.sigs.k8s.io/clusterctl/configuration.html#image-overrides

Change-Id: Id9de8d1967e49aeb3293f6802e51d66d598333ae
Closes: #350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirajyasin sirajyasin

Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@jezogwza @sb464f @sirajyasin @sreejithpunnapuzha @airshipbot