Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl: Allow set ImageRepository and ImageTag for certmanager #2555

Closed
fabriziopandini opened this issue Mar 5, 2020 · 3 comments · Fixed by #2558
Closed

clusterctl: Allow set ImageRepository and ImageTag for certmanager #2555

fabriziopandini opened this issue Mar 5, 2020 · 3 comments · Fixed by #2558
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 5, 2020

User Story

As an operator I would like to use my own image repository for the cert-manager

Detailed Description
The cert-manager manifest is embedded in clusterctl so it cannot be easily changed like e.g. provider manifests. So configuration flags are required to allow to set imageRepository/ImageTag (similar to ImageMeta for etcd/CoreDns in kubeadm)

Anything else you would like to add:
I prefer to use the config file vs flags because it makes the configuration persistent and it ensures consistency between init and upgrades.
The configuration can be something similar (only the image overrides part):

# custom providers
providers:
  - name: docker
    url: /Users/fpandini/.cluster-api/overrides/infrastructure-docker/latest/infrastructure-components.yaml
    type: InfrastructureProvider

# Values for env variables substitutes in provider assets
AWS_B64ENCODED_CREDENTIALS: xxxx

# image overrides
images:
  cert-manager:
    repository: us.gcr.io/myRepo/cluster-api
    tag: v0.13.5 

This can easily evolve into

images:
  all:
    repository: us.gcr.io/myRepo/cluster-api
  cert-manager:
    tag: v0.13.5 

Supporting overrides for all the components or into supporting more granular type of images mutation if the needs arise

/kind feature
/cc @vincepri
/cc @ncdc

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2020
@vincepri
Copy link
Member

vincepri commented Mar 5, 2020

I'm fine using the configuration file if that's easier, the example you posted looks good to me

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 5, 2020
@ncdc
Copy link
Contributor

ncdc commented Mar 5, 2020

config file ++ LGTM thx 😄

@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2020

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants