Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved access to the cloud-init interface #3064

Closed
alanmeadows opened this issue May 14, 2020 · 9 comments
Closed

Improved access to the cloud-init interface #3064

alanmeadows opened this issue May 14, 2020 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@alanmeadows
Copy link

alanmeadows commented May 14, 2020

/kind feature

Describe the solution you'd like
The kubeadm bootstrap provider should support additional cloud-init interfaces that are commonly used in production systems.

Today, only a few are supported: https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/cloudinit/cloudinit.go#L34-L42

Even some of these options, for instance, NTP, do not support the full gamut of available options:

For example: https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ntp#ntp

While you can use these basic building blocks, for instance, writing files or scripts, and calling them prior to join via PreKubeadmC, end-users will end up with operating system specific scriptlets baked into their kubeadm config yaml for common operations such as partitioning secondary storage, mounting it, and so on. For example:

https://cloudinit.readthedocs.io/en/latest/topics/examples.html#adjust-mount-points-mounted
https://cloudinit.readthedocs.io/en/latest/topics/examples.html#disk-setup

@ncdc ncdc transferred this issue from kubernetes-retired/cluster-api-bootstrap-provider-kubeadm May 14, 2020
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2020
@alanmeadows
Copy link
Author

Parts of this may be a duplicate of #2994

@vincepri
Copy link
Member

cc @CecileRobertMichon

@CecileRobertMichon
Copy link
Contributor

@alanmeadows see #3066 and proposal #3048. That proposal is scoped to disk_setup, fs_setup, and mounts.

@vincepri
Copy link
Member

/milestone Next

Needs more discussion on the future of CABPK.

@k8s-ci-robot k8s-ci-robot added this to the Next milestone May 20, 2020
@detiber
Copy link
Member

detiber commented May 20, 2020

One of the things we've discussed in the past is honoring the Format field to support outputting config other than cloud-init (such as ignition or other bootstrapping tools): #1582

If we do still intend to do that, then we need to be cautious around what config fields we support since there is not 100% parity between the different bootstrapping tools as to the features they support.

As @CecileRobertMichon and others mentioned in other conversations related to this topic, it would be great if we could find a way to disentangle the cloud-init requirement from the bootstrap provider as it sits today and have a way for it to do it's thing closer to the point of use rather than the way we currently use it today.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@detiber
Copy link
Member

detiber commented Aug 18, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2020
@vincepri
Copy link
Member

Closing in favor of #3761

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

Closing in favor of #3761

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants