Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CABPK: Support disk_setup and mounts in cloud-init #2994

Closed
CecileRobertMichon opened this issue May 1, 2020 · 7 comments · Fixed by #3066
Closed

CABPK: Support disk_setup and mounts in cloud-init #2994

CecileRobertMichon opened this issue May 1, 2020 · 7 comments · Fixed by #3066
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@CecileRobertMichon
Copy link
Contributor

This is to support mounting etcd on a data disk.

CAEP: https://docs.google.com/document/d/12eYcQrlZdkojHY3atUCCIS9YGPQ1LSQvT4gdg6JWroc/edit?usp=sharing

(shared edit permissions with the kubernetes-sig-cluster-lifecycle google group).

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2020
@vincepri
Copy link
Member

vincepri commented May 1, 2020

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone May 1, 2020
@vincepri
Copy link
Member

vincepri commented May 1, 2020

+1 from me, have some thoughts about extra validation bits, overall having looked at the POC + the proposal, the implementation looks pretty straightforward.

@CecileRobertMichon
Copy link
Contributor Author

/assign

@voor
Copy link
Member

voor commented May 1, 2020

I really like this proposal, as it's going to open up the option of putting /var/lib/containerd and /var/log onto separate partitions as well (I need /home on another partition, but that's more for legacy compliance reasons than anything).

@CecileRobertMichon
Copy link
Contributor Author

For anyone who is interested, I have a working prototype of this with these changes:

@randomvariable
Copy link
Member

+1 on this

@dhawal55
Copy link

dhawal55 commented May 13, 2020

+1
This enables me to have separate volume mounts for /var/lib/docker, /var/lib/kubelet and etcd data dir

I would like to see this change in other infrastructure providers (vpshere, aws) as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants