Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete gcp-deployer and tf-deployer directories #230

Closed
rsdcastro opened this issue May 29, 2018 · 11 comments · Fixed by #429
Closed

Delete gcp-deployer and tf-deployer directories #230

rsdcastro opened this issue May 29, 2018 · 11 comments · Fixed by #429
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@rsdcastro
Copy link

rsdcastro commented May 29, 2018

This issue tracks clusterctl being the primary and only bootstrapping mechanism, with all the functionality that is currently in gcp-deployer and tf-deployer.

Current set of directories is: gcp-deployer, tf-deployer, and vsphere-deployer.

@rsdcastro rsdcastro added this to the cluster-api-alpha-implementation milestone May 29, 2018
@rsdcastro
Copy link
Author

Can we have a list of what this entails?

@karan Karan - can you confirm that "clusterctl create" has everything we need to get rid of the tf-deployer, otherwise can you file bugs and list them here? Once done, please assign to @mkjelland for equivalent GCP audit.

@rsdcastro
Copy link
Author

/assign @karan

@karan
Copy link
Contributor

karan commented May 29, 2018

Primarily, bootstrapping is what we are waiting for - #157

Once that's done, we can deprecate the existing tools.

@rsdcastro
Copy link
Author

@mkjelland Just to confirm: is #157 sufficient to delete gcp-deployer?

@mkjelland
Copy link
Contributor

mkjelland commented May 30, 2018

@rsdcastro Yes, once that issue is done the gcp-deployer can be deleted. Although deletion might get a little more painful in the short term, because that issue is only for cluster creation. Issue #20 will also need to be done so that people know how to delete their clusters.

@roberthbailey
Copy link
Contributor

Renaming since we now have gcp-deployer, tf-deployer, and vsphere-deployer directories.

@karan
Copy link
Contributor

karan commented Jun 5, 2018

Since clusterctl create cluster works for vsphere and gcp, we should be okay to delete *-deployer. We can do it tomorrow, after discussing in the community meeting.

@roberthbailey
Copy link
Contributor

Sweet!

@spew
Copy link
Contributor

spew commented Jun 6, 2018

/assign @karan

@karan
Copy link
Contributor

karan commented Jun 6, 2018

Okay so we have decided to hold off on deleting gcp-deployer for a few more days until the existing integration test is migrated and cluster delete works (@spew is working on that). vsphere and tf deployers will be deleted in the meantime.

@karan
Copy link
Contributor

karan commented Jun 6, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 6, 2018
@roberthbailey roberthbailey self-assigned this Jul 24, 2018
chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
…o-make-test

✨ Add lint to make test command
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
…etes-sigs#231)

Ubuntu updated the docker version on their server that causes kubeadm init to fail.
It is preventing clusterctl from creating target clusters.  Currently, we pull the
latest version of docker off of Ubuntu's servers, which at this time is 18.09.2.
This change will pin the docker version to 18.06.x.

Resolves kubernetes-sigs#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants