Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete vsphere-deployer, tf-deployer. Mark gcp-deployer deprecated. #284

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Delete vsphere-deployer, tf-deployer. Mark gcp-deployer deprecated. #284

merged 1 commit into from
Jun 6, 2018

Conversation

karan
Copy link
Contributor

@karan karan commented Jun 6, 2018 •
edited
Loading

What this PR does / why we need it: Deletes the now unnecessary deployer tools in favor of clusterctl. I've also updated documentation where needed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

#230

Not merging until after the community meeting on June 6.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 6, 2018
@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

/assign @spew
/assign @jessicaochen

/cc @rsdcastro @roberthbailey @kris-nova

@spew
Copy link
Contributor

spew commented Jun 6, 2018 •
edited
Loading

Thanks for opening this PR @karan. My thoughts are we should have feature parity in clusterctl before doing this (i.e. delete doesn't work yet)?

I see we are waiting for the community meeting so no response needed.

@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

In #230 we decided to make cluster deletion a little painful in the short-term, but using documentation instead. GCE in #261, vsphere in #286.

@karan karan changed the title Delete gcp-deployer, vsphere-deployer, tf-deployer Delete vsphere-deployer, tf-deployer. Mark gcp-deployer deprecated. Jun 6, 2018
@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

Okay so we have decided to hold off on deleting gcp-deployer for a few more days until the existing integration test is migrated (@spew is working on that). This PR has been updated to delete only vsphere and tf deployers in the meantime.

@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

/retest

jessicaochen
jessicaochen suggested changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@jessicaochen jessicaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit and a high level question.

High level question:

  • clusterctl does not have support for terraform. It supports vsphere and gce at the moment. If we delete tf-deployer, then there will be no deployment tool for tf. Who uses the terraform stuff and do they need the tf-deployer still?

CONTRIBUTING.md
@@ -70,7 +70,7 @@ You can find an example implementation for GCE [here](https://github.com/kuberne

##### GCE Implementation

For GCE, a [yaml file](https://github.com/kubernetes-sigs/cluster-api/blob/master/gcp-deployer/machine_setup_configs.yaml) holds the list of valid machine setup configs,
For GCE, a [config map](https://github.com/kubernetes-sigs/cluster-api/blob/6aecf9c80a1ca29b45cb43ebfd50ac0d57eb7132/clusterctl/examples/google/provider-components.yaml.template#L118) holds the list of valid machine setup configs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional to lock to a specific revision instead of using master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The template is changing a lot and line numbers move around quite a bit.

@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

Afaik, no one uses tf-deployer. The agreement was to not delete the provider for now, and others are free to work on it (including integrating with clusterctl).

jessicaochen
jessicaochen approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@jessicaochen jessicaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Seems reasonable.

lgtm (leaving backslash to your second reviewer)

@roberthbailey
Copy link
Contributor

@dims expressed interest in extending the tf deployer to work with openstack but afaik hasn't started yet. I think we are saying that at this point he should build support into clusterctl instead.

@dims
Copy link
Member

dims commented Jun 6, 2018

That's fair @roberthbailey thanks!

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2018
@karan
Copy link
Contributor Author

karan commented Jun 6, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 86ffc8e into kubernetes-sigs:master Jun 6, 2018
@karan karan deleted the nuke-em branch June 6, 2018 23:50
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
@karan @k8s-ci-robot
Delete vsphere-deployer, tf-deployer. Add deprecation note on (kubern…
8a2e5ff 
…etes-sigs#284)

gcp-deployer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaochen jessicaochen jessicaochen approved these changes

@krisnova krisnova Awaiting requested review from krisnova

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@rsdcastro rsdcastro Awaiting requested review from rsdcastro

Assignees

@spew spew

@roberthbailey roberthbailey

@jessicaochen jessicaochen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karan @k8s-ci-robot @spew @roberthbailey @dims @jessicaochen