Convert AKS e2e tests to SDKv2 #4026
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4026 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 187 187
Lines 19130 19130
=======================================
Hits 10823 10823
Misses 7676 7676
Partials 631 631 ☔ View full report in Codecov by Sentry. |
|
/test pull-cluster-api-provider-azure-e2e-optional There shouldn't be any side effects here, but I'm not taking chances. |
| if semver.MajorMinor(orchVersion) == semver.MajorMinor(maxVersion) && semver.Compare(orchVersion, maxVersion) >= 0 { | ||
| maxVersion = orchVersion | ||
| foundWorkingVersion = true | ||
| for _, minor := range result.KubernetesVersionListResult.Values { |
There was a problem hiding this comment.
This API changed from SDK v1 to v2, so we have to iterate versions slightly differently.
There was a problem hiding this comment.
since we already know the minor of the desired AKS minor version do we really need to range over all patches of all minors?
There was a problem hiding this comment.
Good point, we can do the MajorMinor comparison first in the loop and just continue if they aren't the same. I'll change that.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a30493c7c1088cce83aad12f2a2c71fe61f2d25b
|
mboersma
force-pushed
the
sdk-v2-e2e-aks
branch
from
1175e2f to
07314a7
Compare
k8s-ci-robot
removed
the
lgtm
|
Squashed. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 281df35ad683ae4bbc9cbe3edbdbe7e29fd201d6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Converts references in the AKS e2e tests to azure-sdk-for-go version 2.
Which issue(s) this PR fixes:
Refs #3985
Special notes for your reviewer:
I split this out from #3991 to make it easier to review (and to troubleshoot the remaining failure in that PR).
TODOs:
Release note: