Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update /test to SDKv2 #3985

Closed
Tracked by #3409
mboersma opened this issue Sep 11, 2023 · 2 comments · Fixed by #3991
Closed
Tracked by #3409

Update /test to SDKv2 #3985

mboersma opened this issue Sep 11, 2023 · 2 comments · Fixed by #3991
Assignees
@mboersma
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.12

Comments

@mboersma
Copy link
Contributor

No description provided.

@mboersma mboersma mentioned this issue Sep 11, 2023
Closed
@mboersma
Copy link
Contributor Author

mboersma commented Sep 11, 2023 •
edited
Loading

The e2e tests often construct their own SDK clients to do validation. These are (almost) all still using SDKv1, but need to be updated. See the managedclusters SDKv2 PR for an example of how to convert:

cluster-api-provider-azure/test/e2e/aks_azure_cluster_autoscaler.go

Lines 50 to 53 in 8720410

cred, err := azidentity.NewDefaultAzureCredential(nil)
Expect(err).NotTo(HaveOccurred())
containerserviceClient, err := armcontainerservice.NewManagedClustersClient(subscriptionID, cred, nil)
Expect(err).NotTo(HaveOccurred())

@mboersma mboersma added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 11, 2023
@mboersma
Copy link
Contributor Author

/assign

@mboersma mboersma mentioned this issue Sep 12, 2023
Merged
4 tasks
@mboersma mboersma moved this to In Progress in CAPZ Planning Sep 12, 2023
@mboersma mboersma added this to the v1.11 milestone Sep 12, 2023
@dtzar dtzar modified the milestones: v1.11, v1.12 Sep 18, 2023
@mboersma mboersma mentioned this issue Sep 21, 2023
Merged
4 tasks
@mboersma mboersma moved this from In Progress to Needs Review in CAPZ Planning Sep 29, 2023
@mboersma mboersma moved this from Needs Review to Todo in CAPZ Planning Sep 29, 2023
@mboersma mboersma moved this from Todo to In Progress in CAPZ Planning Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CAPZ Planning Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboersma mboersma

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging a pull request may close this issue.

Convert /test references to SDKv2 mboersma/cluster-api-provider-azure
2 participants
@mboersma @dtzar