Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert /test references to SDKv2 #3991

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Convert /test references to SDKv2 #3991

merged 1 commit into from
Oct 2, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Converts references in the /test directory to azure-sdk-for-go version 2.

Which issue(s) this PR fixes:

Fixes #3985

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@mboersma
Copy link
Contributor Author

/retitle [WIP] Convert /test references to SDKv2

There's more to change here, but I'm taking baby steps.

@k8s-ci-robot k8s-ci-robot changed the title Convert /test references to SDKv2 [WIP] Convert /test references to SDKv2 Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
mboersma
mboersma commented Sep 12, 2023
View reviewed changes
test/e2e/azure_securitygroups.go
Expect(err).NotTo(HaveOccurred())

By("creating a subnets client")
subnetsClient := network.NewSubnetsClient(subscriptionID)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This subnetsClient wasn't actually being used.

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4d959b) 56.66% compared to head (69a8f71) 56.65%.
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3991      +/-   ##
==========================================
- Coverage   56.66%   56.65%   -0.02%     
==========================================
  Files         187      187              
  Lines       19143    19143              
==========================================
- Hits        10848    10846       -2     
- Misses       7666     7668       +2     
  Partials      629      629

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma mboersma added this to the v1.11 milestone Sep 12, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Sep 12, 2023 •
edited
Loading

/test pull-cluster-api-provider-azure-e2e-optional

There is still test/e2e/azure_privatecluster.go to add, but I want to see that we haven't already broken anything.

@mboersma
Copy link
Contributor Author

Must have broken something in GetAKSKubernetesVersion() (although the AKS test passed locally). I'm investigating.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2023
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

For the private cluster test spec.

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

1 similar comment
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@mboersma
Copy link
Contributor Author

Yay, AKS is passing now. I'm looking into the VMSS flex failure, then the private cluster spec.

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@dtzar dtzar modified the milestones: v1.11, v1.12 Sep 18, 2023
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@mboersma mboersma mentioned this pull request Sep 21, 2023
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 28, 2023
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@mboersma
Copy link
Contributor Author

/retest

1 similar comment
@mboersma
Copy link
Contributor Author

/retest

@mboersma mboersma mentioned this pull request Sep 29, 2023
Closed
@mboersma
Copy link
Contributor Author

/retitle Convert /test references to SDKv2

I've removed the private cluster-specific changes from this PR so I can troubleshoot that separately (see #4056). These changes appear to work (on the private cluster test as well).

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Convert /test references to SDKv2 Convert /test references to SDKv2 Sep 29, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Oct 2, 2023

/cc @CecileRobertMichon @nojnhuh

nojnhuh
nojnhuh reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4f7c1a3d0d9a2cfa1b847c79d600cd5c99ac23c

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0e559d5 into kubernetes-sigs:main Oct 2, 2023
10 checks passed
@mboersma mboersma deleted the sdk-v2-e2e-tests branch October 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Update /test to SDKv2
5 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @nojnhuh @dtzar