Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding HTTP Proxy support for managed cluster #3847

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Adding HTTP Proxy support for managed cluster #3847

merged 1 commit into from
Aug 18, 2023

Conversation

mjnovice
Copy link
Contributor

@mjnovice mjnovice commented Aug 15, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3485

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Adding HTTP proxy support for managed cluster

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mjnovice. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2023
@mjnovice mjnovice changed the title Adding HTTPS support for managed cluster Adding HTTP Proxy support for managed cluster Aug 15, 2023
@mjnovice mjnovice changed the title Adding HTTP Proxy support for managed cluster WIP Adding HTTP Proxy support for managed cluster Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@CecileRobertMichon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2023
@mjnovice mjnovice changed the title WIP Adding HTTP Proxy support for managed cluster Adding HTTP Proxy support for managed cluster Aug 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@mjnovice
Copy link
Contributor Author

/retest

@mjnovice
Copy link
Contributor Author

/retest

@mjnovice
Copy link
Contributor Author

/retest

Jont828
Jont828 reviewed Aug 16, 2023
View reviewed changes
api/v1beta1/azuremanagedcontrolplane_types.go Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_types.go Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_types.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_types.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_types.go Outdated Show resolved Hide resolved
azure/services/managedclusters/spec.go Outdated Show resolved Hide resolved
@Jont828
Copy link
Contributor

Jont828 commented Aug 16, 2023

/retest pull-cluster-api-provider-azure-e2e

@k8s-ci-robot
Copy link
Contributor

@Jont828: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-ci-entrypoint
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-aks
  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-apiversion-upgrade
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-conformance
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-e2e-optional
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify

In response to this:

/retest pull-cluster-api-provider-azure-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jont828
Copy link
Contributor

Jont828 commented Aug 16, 2023

/test pull-cluster-api-provider-azure-e2e

@Jont828
Copy link
Contributor

Jont828 commented Aug 16, 2023

Looks like you had a failure with the VMSS e2e test, rerunning in case it's a flake.

@Jont828 Jont828 self-assigned this Aug 16, 2023
@Jont828
Copy link
Contributor

Jont828 commented Aug 16, 2023

/assign

@mjnovice mjnovice requested a review from Jont828 August 16, 2023 20:05
@mjnovice mjnovice force-pushed the mj/proxy-support branch 3 times, most recently from 82d36e7 to 6c44b7c Compare August 16, 2023 21:11
@Jont828
Copy link
Contributor

Jont828 commented Aug 16, 2023

@mjnovice The verify error seems to be a linting issue with the shellcheck script.

@nawazkh
Copy link
Member

nawazkh commented Aug 16, 2023

My comment might have gotten buried into resolved comments, but I would love to hear your thoughts @mjnovice

@mjnovice mjnovice requested a review from nawazkh August 16, 2023 22:27
@mjnovice
Copy link
Contributor Author

@mjnovice The verify error seems to be a linting issue with the shellcheck script.

@Jont828 seems to be a ratelimit issue ? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/3847/pull-cluster-api-provider-azure-verify/1691920826074402816#1:build-log.txt%3A510

@mjnovice
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-verify

@mjnovice
Copy link
Contributor Author

My comment might have gotten buried into resolved comments, but I would love to hear your thoughts @mjnovice

@nawazkh have replied to your comment. 🙂 let me know your thoughts.

@nawazkh
Copy link
Member

nawazkh commented Aug 17, 2023

Thanks for the explanation @mjnovice
Looks good to me!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: afb3af912078a859733a4270516d8b71d3d851a7

@Jont828
Copy link
Contributor

Jont828 commented Aug 17, 2023

I've seen a Docker rate limiting issue when testing locally, but I haven't seen that in the CI jobs. If it comes up again we could open an issue.

Jont828
Jont828 reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick thing, otherwise I think we're good to go!

azure/services/managedclusters/spec.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Jont828 August 18, 2023 02:21
Jont828
Jont828 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dde1e38395dd5ecbd9ee295486cab45ff9369257

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0bc07db into kubernetes-sigs:main Aug 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 18, 2023
@jackfrancis jackfrancis mentioned this pull request Jan 31, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Jont828 approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@nawazkh nawazkh Awaiting requested review from nawazkh

Assignees

@Jont828 Jont828

@nawazkh nawazkh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Support AKS cluster with HTTP Proxy mode
5 participants
@mjnovice @k8s-ci-robot @CecileRobertMichon @Jont828 @nawazkh