Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jonathan Tong to maintainers #4526

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Jonathan has consistently demonstrated expertise and endurance on the CAPZ project, and we will be grateful to have him as a maintainer.

Here is a list of substantial PRs primarily reviewed by Jonathan:

Thank you, Jonathan!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (697fa5d) 62.09% compared to head (cfab81d) 62.24%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
+ Coverage   62.09%   62.24%   +0.14%     
==========================================
  Files         191      192       +1     
  Lines       18894    19007     +113     
==========================================
+ Hits        11733    11830      +97     
- Misses       6509     6524      +15     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jont828
Copy link
Contributor

Jont828 commented Jan 31, 2024

Thanks for the nomination @jackfrancis, it's been a pleasure to work with everyone!

@willie-yao
Copy link
Contributor

/lgtm

Congrats Jonathan! You have done some amazing work for this project and this is well deserved 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b87870b44fc9ad335f55246560b3d59ed28db1aa

OWNERS_ALIASES Outdated Show resolved Hide resolved
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jont828 has been productive and dedicated to CAPZ (and to the sig-cluster-lifecycle universe) for many moons. Congratulations and thank you for stepping up!

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 1, 2024

+1, thank you @Jont828!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
Signed-off-by: Jack Francis <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mboersma February 1, 2024 19:57
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ccfa8d77f581971a8f89a68f07a1b46ac7ecd8e

@k8s-ci-robot k8s-ci-robot merged commit 2522297 into kubernetes-sigs:main Feb 1, 2024
17 checks passed
@nawazkh
Copy link
Member

nawazkh commented Feb 1, 2024

Late to the party, but yay! Keep up the good work!
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants