-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jonathan Tong to maintainers #4526
Add Jonathan Tong to maintainers #4526
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4526 +/- ##
==========================================
+ Coverage 62.09% 62.24% +0.14%
==========================================
Files 191 192 +1
Lines 18894 19007 +113
==========================================
+ Hits 11733 11830 +97
- Misses 6509 6524 +15
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. |
Thanks for the nomination @jackfrancis, it's been a pleasure to work with everyone! |
/lgtm Congrats Jonathan! You have done some amazing work for this project and this is well deserved 🚀 |
LGTM label has been added. Git tree hash: b87870b44fc9ad335f55246560b3d59ed28db1aa
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Jont828 has been productive and dedicated to CAPZ (and to the sig-cluster-lifecycle universe) for many moons. Congratulations and thank you for stepping up!
+1, thank you @Jont828! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jack Francis <[email protected]>
29c789b
to
cfab81d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3ccfa8d77f581971a8f89a68f07a1b46ac7ecd8e
|
Late to the party, but yay! Keep up the good work! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Jonathan has consistently demonstrated expertise and endurance on the CAPZ project, and we will be grateful to have him as a maintainer.
Here is a list of substantial PRs primarily reviewed by Jonathan:
Thank you, Jonathan!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: