Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AKS cluster with HTTP Proxy mode #3485

Closed
mjnovice opened this issue Apr 26, 2023 · 3 comments · Fixed by #3847
Closed

Support AKS cluster with HTTP Proxy mode #3485

mjnovice opened this issue Apr 26, 2023 · 3 comments · Fixed by #3847
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mjnovice
Copy link
Contributor

⚠️ Cluster API Azure maintainers can ask to turn an issue-proposal into a CAEP when necessary. This is to be expected for large changes that impact multiple components, breaking changes, or new large features.

Goals

  1. Ability to create AKS clusters with http_proxy support https://learn.microsoft.com/en-us/azure/aks/http-proxy

Non-Goals/Future Work

  1. Non-Goal 1
  2. Non-Goal 2

User Story

As a [developer/user/operator] I would like to be able to create a Azure managed Cluster ( with AzureManagedControlPlane/AzureManagedMachinePool ) using the HTTP_PROXY mode.

Detailed Description

AzureManagedControlPlane can have a field httpProxyConfig akin to
image
allowing us to create the cluster with proxy mode.

/kind proposal

@k8s-ci-robot k8s-ci-robot added the kind/proposal Issues or PRs related to proposals. label Apr 26, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 26, 2023

Looks good, thanks! I think this is small enough that we can classify this as a regular feature request instead of a proposal. No need to change the description though.

/remove-kind proposal
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/proposal Issues or PRs related to proposals. labels Apr 26, 2023
@mjnovice
Copy link
Contributor Author

@nojnhuh I would be willing to work on this, just curious, can we go with making changes with autorest client for now, or do we have a guidance for new features ? Any help would be great

@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 26, 2023

I don't think adding this feature will require any new use of autorest so I think following the existing pattern is a good place to start. If you run into any specific cases feel free to ask then or we can address those once you have a PR open.

Thanks for picking this up!

/assign @mjnovice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants