-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new naming scheme for SKUs and versions #2302
Conversation
6b71e49
to
f169c61
Compare
👷 Deploy request for kubernetes-sigs-cluster-api-provider-azure pending review.Visit the deploys page to approve it
|
50463a5
to
4f8c87a
Compare
b8550e0
to
48d6fd9
Compare
/retest |
/retest-required |
@jsturtevant or @Jont828, could you take a look at this when time permits? |
Yeah sure thing, happy to take a look. |
48d6fd9
to
0481cff
Compare
Thanks @Jont828, I made all your suggested changes and they definitely improved the unit tests. 👍🏻 |
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mboersma I just realized the SKU name change is also going to break our e2e logic that selects the latest SKU available for a given k8s major.minor https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/test/e2e/helpers.go#L777
We can merge this one now to unblock users and address e2e separately, the tests will just be stuck at the latest version that was published with the old naming until we fix them.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
D'oh, you're right. I can take on that change to e2e logic. |
/cherry-pick release-1.3 |
@mboersma: new pull request created: #2357 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?:
/kind feature
What this PR does / why we need it:
This catches up with the SKU and version naming changes in kubernetes-sigs/image-builder#878
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
TODOs:
Release note: