simplify ci-entrypoint.sh

[jackfrancis]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes the USE_CI_ARTIFACTS option (by convention USE_CI_ARTIFACTS=true is supported; any non-zero value to USE_CI_ARTIFACTS effectively means boolean true) as the existing KUBERNETES_VERSION=latest interface provides the same functionality with more semantic expressiveness.

Additionally, we remove the inferential check to see if k/k is in the GOPATH, and to use the checked out sha as the KUBERNETES_VERSION. Going forward we will require usages of ci-entrypoint.sh to declare the desired version of Kubernetes to build via the KUBERNETES_VERSION environment variable (this is already the practice in the vast majority of test-infra jobs).

This test-infra PR needs to merge first so that we are sure we remove any automated usages of the deprecated config interface!:

kubernetes/test-infra#26397

Finally, we add support for using the "stable" prefix to automatically gather the latest patch release. Using 1.23 as an example, "stable-1.23" will yield "v1.23.7" at the time of this writing. Simply using "stable" yields "v1.24.1" at the time of this writing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[jackfrancis]

/hold until kubernetes/test-infra#26397 merges

[marosset]

I think that specifying KUBERNETES_VERSION as anything with 'latest' will not work for Windows.

That would cause this envsubst to container a pre-release tag and therefore not match to any of the kubeproxy images for windows that we currently maintain.

cluster-api-provider-azure/templates/test/ci/cluster-template-prow-ci-version.yaml

Line 624 in 0298a7d

true\n containers:\n - image: sigwindowstools/kube-proxy:${KUBERNETES_VERSION/+/_}-calico-hostprocess\n

I'll try testing this out manually by checking out from this PR branch and trying to build a cluster.

[marosset]

I think that specifying KUBERNETES_VERSION as anything with 'latest' will not work for Windows.

That would cause this envsubst to container a pre-release tag and therefore not match to any of the kubeproxy images for windows that we currently maintain.

cluster-api-provider-azure/templates/test/ci/cluster-template-prow-ci-version.yaml

Line 624 in 0298a7d

true\n containers:\n - image: sigwindowstools/kube-proxy:${KUBERNETES_VERSION/+/_}-calico-hostprocess\n

I'll try testing this out manually by checking out from this PR branch and trying to build a cluster.

I was mis-informed and it looks like this DOES work for Windows.
It looks like we pull an arbitrary kube-proxy image and then tag it as `sigwindowstools/kube-proxy:${CI_VERSION/+/_}-calico-hostprocess

cluster-api-provider-azure/templates/test/ci/prow-ci-version/patches/kubeadm-bootstrap-windows.yaml

Line 33 in ecb2562

ctr.exe -n k8s.io images tag docker.io/sigwindowstools/kube-proxy:v1.23.1-calico-hostprocess "docker.io/sigwindowstools/kube-proxy:${CI_VERSION/+/_}-calico-hostprocess"

[CecileRobertMichon]

since kubernetes/test-infra#26397 already merged, is this ready to go?

[CecileRobertMichon]

we can add another elif here if we want to support stable versions and resolve to CI_VERSION_URL="https://dl.k8s.io/release/${KUBERNETES_VERSION}.txt

[CecileRobertMichon]

actually for stable- versions we don't need the ci-version template since it will just resolve to the latest released patch version, example https://storage.googleapis.com/kubernetes-release/release/stable-1.23.txt is v1.23.7 right now, so it needs to be outside the if statement that sets the template to cluster-template-prow-ci-version.yaml.

We can do this in a separate PR too.

[jackfrancis]

yeah, you're right, see my latest change

I think this is a simple enough addition that is makes sense to incorporate it in here

[jackfrancis]

I've audited tests since kubernetes/test-infra#26397 merged and I don't observe any regressions.

This PR is ready for final review/merge.

/assign @CecileRobertMichon

[CecileRobertMichon]

/lgtm

[CecileRobertMichon]

/assign @mboersma

@jackfrancis ready to remove the hold?

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/hold cancel

[jackfrancis]

/cherry-pick release-1.3

[k8s-infra-cherrypick-robot]

@jackfrancis: new pull request created: #2363

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.