Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPZ: fix kubernetes version in apiversion test #26755

Merged
merged 1 commit into from
Jul 6, 2022
Merged

CAPZ: fix kubernetes version in apiversion test #26755

merged 1 commit into from
Jul 6, 2022

Conversation

CecileRobertMichon
Copy link
Member

Fixes https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-apiversion-upgrade-main

The apiversion upgrade test attempts to create a test workload cluster from an "old" management cluster (created with capz v1alpha4). However, CAPZ v0.5.x does not support new Kubernetes versions due to the SKU naming change (kubernetes-sigs/cluster-api-provider-azure#2302).

Since CAPZ e2e tests were updated to use the latest version available in new image SKUs, this test broke as the older management cluster is unable to find the new images. This pins the test to the latest supported 1.22 version in v1alpha4.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 6, 2022
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jul 6, 2022
Merged
3 tasks
@CecileRobertMichon
Copy link
Member Author

/assign @jackfrancis

cc @mboersma

@CecileRobertMichon
Copy link
Member Author

/retest

jackfrancis
jackfrancis approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f9285f into kubernetes:master Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics-main.yaml
  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
  • key cluster-api-provider-azure-presubmits-release-v1beta1.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml

In response to this:

Fixes https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-apiversion-upgrade-main

The apiversion upgrade test attempts to create a test workload cluster from an "old" management cluster (created with capz v1alpha4). However, CAPZ v0.5.x does not support new Kubernetes versions due to the SKU naming change (kubernetes-sigs/cluster-api-provider-azure#2302).

Since CAPZ e2e tests were updated to use the latest version available in new image SKUs, this test broke as the older management cluster is unable to find the new images. This pins the test to the latest supported 1.22 version in v1alpha4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@jackfrancis jackfrancis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@CecileRobertMichon @k8s-ci-robot @jackfrancis