Fix outbound lb conversion for v1alpha3 clusters

[shysank]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fixes outbound load balancer conversion logic for v1alpha3 clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2175

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Fix outbound lb conversion for v1alpha3 clusters

[shysank]

/test pull-cluster-api-provider-azure-e2e

[CecileRobertMichon]

/test ls

[k8s-ci-robot]

@CecileRobertMichon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-azure-build
• /test pull-cluster-api-provider-azure-e2e
• /test pull-cluster-api-provider-azure-test
• /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-azure-apidiff
• /test pull-cluster-api-provider-azure-apiversion-upgrade
• /test pull-cluster-api-provider-azure-capi-e2e
• /test pull-cluster-api-provider-azure-ci-entrypoint
• /test pull-cluster-api-provider-azure-conformance
• /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-azure-coverage
• /test pull-cluster-api-provider-azure-e2e-exp
• /test pull-cluster-api-provider-azure-e2e-optional
• /test pull-cluster-api-provider-azure-e2e-workload-upgrade
• /test pull-cluster-api-provider-azure-upstream-windows-dockershim
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
• /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-azure-apidiff
• pull-cluster-api-provider-azure-build
• pull-cluster-api-provider-azure-ci-entrypoint
• pull-cluster-api-provider-azure-coverage
• pull-cluster-api-provider-azure-e2e
• pull-cluster-api-provider-azure-test
• pull-cluster-api-provider-azure-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/test pull-cluster-api-provider-azure-apiversion-upgrade

to make sure it doesn't affect other upgrade scenarios

[shysank]

/test pull-cluster-api-provider-azure-apiversion-upgrade

[CecileRobertMichon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shysank]

/cherry-pick release-1.1

[k8s-infra-cherrypick-robot]

@shysank: #2176 failed to apply on top of branch "release-1.1":

Applying: fix outbound lb conversion for v1alpha3 clusters
Using index info to reconstruct a base tree...
M	api/v1alpha3/azurecluster_conversion.go
M	api/v1beta1/azurecluster_default.go
M	api/v1beta1/azurecluster_default_test.go
Falling back to patching base and 3-way merge...
Auto-merging api/v1beta1/azurecluster_default_test.go
Auto-merging api/v1beta1/azurecluster_default.go
CONFLICT (content): Merge conflict in api/v1beta1/azurecluster_default.go
Auto-merging api/v1alpha3/azurecluster_conversion.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix outbound lb conversion for v1alpha3 clusters
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shysank]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@shysank: new pull request created: #2185

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.