Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] fix outbound lb conversion for v1alpha3 clusters #2178

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[release-1.1] fix outbound lb conversion for v1alpha3 clusters #2178

merged 1 commit into from
Mar 23, 2022

Conversation

shysank
Copy link
Contributor

@shysank shysank commented Mar 18, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:

Backports #2176

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

cherry pick bot didn't work because there were merge conflicts.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix outbound lb conversion for v1alpha3 clusters

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from juan-lee March 18, 2022 16:25
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mboersma March 18, 2022 16:25
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 18, 2022
@shysank
Copy link
Contributor Author

shysank commented Mar 18, 2022

/test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1

@shysank
Copy link
Contributor Author

shysank commented Mar 21, 2022

cc @CecileRobertMichon

@CecileRobertMichon
Copy link
Contributor

@shysank should this be backported to release-1.2 instead since that's our current release branch?

@shysank
Copy link
Contributor Author

shysank commented Mar 21, 2022

closing in favor of #2185

@shysank shysank closed this Mar 22, 2022
@shysank shysank reopened this Mar 22, 2022
@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

re-opening after slack discussion https://kubernetes.slack.com/archives/CEX9HENG7/p1647967600998299

@CecileRobertMichon CecileRobertMichon changed the title fix outbound lb conversion for v1alpha3 clusters - release 1.1 [release-1.1] fix outbound lb conversion for v1alpha3 clusters Mar 22, 2022
@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

/test pull-cluster-api-provider-azure-e2e-v1beta1

3 similar comments
@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

/test pull-cluster-api-provider-azure-e2e-v1beta1

@shysank
Copy link
Contributor Author

shysank commented Mar 23, 2022

/test pull-cluster-api-provider-azure-e2e-v1beta1

@shysank
Copy link
Contributor Author

shysank commented Mar 23, 2022

/test pull-cluster-api-provider-azure-e2e-v1beta1

@shysank
Copy link
Contributor Author

shysank commented Mar 23, 2022

/retest

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4a53842 into kubernetes-sigs:release-1.1 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-lee juan-lee Awaiting requested review from juan-lee

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shysank @CecileRobertMichon @k8s-ci-robot