Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Fix outbound lb conversion for v1alpha3 clusters #2187

Closed
wants to merge 1 commit into from
Closed

[release-1.0] Fix outbound lb conversion for v1alpha3 clusters #2187

wants to merge 1 commit into from

Conversation

shysank
Copy link
Contributor

@shysank shysank commented Mar 22, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backports #2176

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fix outbound lb conversion for v1alpha3 clusters

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2022
@shysank shysank changed the base branch from main to release-1.0 March 22, 2022 19:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2022
@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

/retest

1 similar comment
@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

/retest

@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

The test failures are because I set the base branch as main by mistake initially.

@shysank
Copy link
Contributor Author

shysank commented Mar 22, 2022

cc @CecileRobertMichon

@k8s-ci-robot
Copy link
Contributor

@shysank: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-build 4cee769 link true /test pull-cluster-api-provider-azure-build
pull-cluster-api-provider-azure-test 4cee769 link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-verify 4cee769 link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-e2e 4cee769 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-apidiff 4cee769 link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-ci-entrypoint 4cee769 link false /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-e2e-exp 4cee769 link false /test pull-cluster-api-provider-azure-e2e-exp
pull-cluster-api-provider-azure-coverage 4cee769 link false /test pull-cluster-api-provider-azure-coverage
pull-cluster-api-provider-azure-ci-entrypoint-v1beta1 4cee769 link false /test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CecileRobertMichon
CecileRobertMichon reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2022
@shysank
Copy link
Contributor Author

shysank commented Mar 23, 2022

closing this because of test failures preventing from merge.

@shysank shysank closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shysank @k8s-ci-robot @CecileRobertMichon