-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[help wanted] refactor remaining services following established pattern #757
Comments
@CecileRobertMichon: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can I take disks? |
Can I take |
/priority important-soon |
💎 cloud: Refactor Disks scope to interface
@CecileRobertMichon can I take subnets? |
@cpanato, go for it! I don't think anyone is working on it right now. |
ok, after the subnet i will take the virtual networks if that is fine |
💎 cloud: Refactor Groups scope to interface
going to work on |
route tables is the last one without a name, I'll take that one |
@alexeldeib changed resource skus to you since you have #783 open |
following the pattern discussed in issue kubernetes-sigs#757
following the pattern discussed in issue kubernetes-sigs#757
following the pattern discussed in issue kubernetes-sigs#757
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I can take that one after the existing "refactoring PRs" get merged |
I can take exp/managedclusters and exp/agentpools. |
thanks @nprokopic |
FYI I finally got to start with AKS refactoring (managed cluster and agent pools), started working on it this week. |
/assign @nprokopic |
/milestone v0.5.x |
FYI I started working on the final part of the refactoring - exp/agentpools. |
We can also tick off exp/managedclusters. |
Following the pattern established in #716, we should refactor each service to follow the same pattern. Each service should have its own refactor PR to make reviewing easier. For example, network interfaces was already done in #742.
disks (@cpanato)
groups (@cpanato)
exp/managedclusters
exp/agentpools
public IPs (@CecileRobertMichon)
network interfaces (@CecileRobertMichon)
load balancers (@CecileRobertMichon)
subnets (@cpanato)
virtual networks (@cpanato)
route tables (@nader-ziada)
inbound nat rules (@CecileRobertMichon)
role assignments (@CecileRobertMichon)
resource skus (@alexeldeib)
securitygroups (@CecileRobertMichon)
exp/scalesets (@CecileRobertMichon)
virtualmachines (@CecileRobertMichon)
Let me know if you want to help with one of these in comments and I'll add your username next to it!
/help
The text was updated successfully, but these errors were encountered: