💎 Refactor inbound NAT rules service #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/provider/azure
CecileRobertMichon
changed the title
devigned
approved these changes
Jul 15, 2020
| @@ -27,7 +27,7 @@ type Service struct { | |||
| Client | |||
| } | |||
|
|
|||
| // GroupScope defines the scope interface for a disk service. | |||
| // GroupScope defines the scope interface for a group service. | |||
There was a problem hiding this comment.
Nice drive by documentation upgrade!
CecileRobertMichon
force-pushed
the
inbound-nat-rules
branch
2 times, most recently
from
e64fe45 to
695f1dd
Compare
| for _, tc := range testcases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| g := NewWithT(t) | ||
| t.Parallel() |
There was a problem hiding this comment.
/hold
need to apply #806 here
There was a problem hiding this comment.
done
/hold cancel
k8s-ci-robot
added
the
do-not-merge/hold
CecileRobertMichon
force-pushed
the
inbound-nat-rules
branch
from
695f1dd to
b19041c
Compare
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @devigned @nader-ziada this is ready for another review fixed the parallelism in tests and re-ran make generate |
CecileRobertMichon
force-pushed
the
inbound-nat-rules
branch
from
b19041c to
d73c831
Compare
|
/test pull-cluster-api-provider-azure-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Uses the new Service interface to break out inbound NAT rule creation / deletion from the network interface service.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partially addresses #757
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: