-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: Refactor managed machine pool #1602
Conversation
Version *string | ||
|
||
// SKU defines Azure VM size for the agent pool VMs. | ||
SKU string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: defines the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
azure/types.go
Outdated
// Replicas is the number of desired machines. | ||
Replicas int32 | ||
|
||
// OSDiskSizeGB is OS disk size in GB for every machine in this agent pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto: is the os disk size..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
azure/types.go
Outdated
// VnetSubnetID is the Azure Resource ID for the subnet which should contain nodes. | ||
VnetSubnetID string | ||
|
||
// Mode represents mode of an agent pool. Possible values include: 'AgentPoolModeSystem', 'AgentPoolModeUser'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the Azure values, not what we expose right? I guess doc'ing them here is fine, but they shouldn't be exposed really.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, thanks. I saw that we just use the same values like Azure SDK code, so I copied this from code docs from Azure SDK (which are then not really correct strings, those are const names from the code 🤦).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values that are in the code doc now are the same as in AzureManagedMachinePoolSpec.Mode
, since those are used here as well.
/lgtm very minor nits, looks good :) nice to finally wrap up all the refactoring! |
37fabd4
to
da0975a
Compare
@nprokopic: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
hmm, maybe a potential flake for me to poke at further? I still had a few changes I was testing... /test pull-cluster-api-provider-azure-e2e-exp |
I'll assume the exp failure was a flake and debug it along with #1488 /lgtm |
The PR lgtm 👍 |
// OldService is a generic interface for services that have not yet been refactored. | ||
// Once all services have been converted to use Service, this should be removed. | ||
// Example: virtualnetworks service would offer Reconcile/Delete methods. | ||
type OldService interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow up from #716, this PR applies the same pattern to managed machine pools.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #757
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: