-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validations for AzureCluster Updates #497
Comments
/help |
@CecileRobertMichon: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
@CecileRobertMichon should we re-scope this issue to just the |
@jackfrancis let's keep this one open and once #522 merges we can make a list of the other properties that should be validated as immutable in this issue for someone else to pick up. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/remove-lifecycle rotten |
/unassign @jackfrancis |
@CecileRobertMichon do you need help in this? |
@surajrana93 have you picked this up already? if not I would like to work on this. |
@furkatgofurov7 go for it, I believe @surajrana93 is already working on #1075 |
/assign |
Fields that we should allow updates on:
Everything else should not be updated. /cc @devigned |
Some fields (eg. Azure location) are immutable and we should fail when they are updated.
To get started, you can look at how we implemented validation for AzureMachines here:
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/api/v1alpha3/azuremachine_webhook.go#L46
and add to https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/api/v1alpha3/azurecluster_webhook.go
You can also look at this PR in CAPA which achieves something similar: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1677/files
The text was updated successfully, but these errors were encountered: