Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for immutable AzureCluster Updates #1098

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Add validations for immutable AzureCluster Updates #1098

merged 1 commit into from
Jan 16, 2021

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Dec 23, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds validations and corresponding unit tests for AzureCluster Updates
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #497

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add validations for AzureCluster Updates

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @furkatgofurov7!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @furkatgofurov7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/azure Issues or PRs related to azure provider labels Dec 23, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2020
@furkatgofurov7
Copy link
Member Author

/assign @CecileRobertMichon
/cc @devigned

@devigned
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2020
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7
Copy link
Member Author

@devigned @CecileRobertMichon I am trying to fix e2e tests and looking for some guidance. As I checked, webhook config for cluster is already in place, am I missing something else to pass the tests?

@devigned
Copy link
Contributor

@furkatgofurov7 seems like something is up with kind. I'm, looking 👀

@devigned
Copy link
Contributor

/retest

4 similar comments
@devigned
Copy link
Contributor

/retest

@devigned
Copy link
Contributor

/retest

@furkatgofurov7
Copy link
Member Author

/retest

@devigned
Copy link
Contributor

devigned commented Jan 4, 2021

/retest

@furkatgofurov7
Copy link
Member Author

@devigned hi! I was wondering if I am missing something to pass e2e tests or whether this is a flake in CI(most probably not), since we already have triggered it multiple times..?

@devigned
Copy link
Contributor

devigned commented Jan 4, 2021

@furkatgofurov7 I think the validating webhook is rejecting updates to the AzureCluster resource as evidenced by the repeated updates here: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/1098/pull-cluster-api-provider-azure-e2e/1346080959979589632/artifacts/clusters/bootstrap/controllers/capz-controller-manager/capz-controller-manager-5d7858d64d-nc2p8/manager.log

If you click on the e2e job, you can see the output of most of the cluster logs in the PR Artifacts link.

Have you been able to verify these changes locally by creating a cluster, perhaps using Tilt?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2021
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7 furkatgofurov7 force-pushed the azCluster-validation-furkat branch 3 times, most recently from 75639f4 to 243cd84 Compare January 8, 2021 23:44
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7
Copy link
Member Author

@CecileRobertMichon @devigned @nader-ziada thanks for reviews/feedbacks, addressed all your comments. PTAL.

@CecileRobertMichon
Copy link
Contributor

@furkatgofurov7 please add a release note as this is a user facing change

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 11, 2021
CecileRobertMichon
CecileRobertMichon reviewed Jan 11, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

please squash the commits @furkatgofurov7

@furkatgofurov7 furkatgofurov7 force-pushed the azCluster-validation-furkat branch from 4ceea1a to 9c0af5b Compare January 11, 2021 17:25
@furkatgofurov7
Copy link
Member Author

@furkatgofurov7 please add a release note as this is a user facing change

Done.

please squash the commits @furkatgofurov7

Done. Thanks for review @CecileRobertMichon .

@furkatgofurov7
Copy link
Member Author

/retest

CecileRobertMichon
CecileRobertMichon approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@furkatgofurov7
Copy link
Member Author

/retest

@CecileRobertMichon
Copy link
Contributor

/retest

#1123 should help with the flakes...

@devigned
Copy link
Contributor

/retest

2 similar comments
@furkatgofurov7
Copy link
Member Author

/retest

@devigned
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9cbfb33 into kubernetes-sigs:master Jan 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.11 milestone Jan 16, 2021
@furkatgofurov7 furkatgofurov7 deleted the azCluster-validation-furkat branch January 16, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nader-ziada nader-ziada nader-ziada left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@devigned devigned Awaiting requested review from devigned

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

Add validations for AzureCluster Updates
5 participants
@furkatgofurov7 @k8s-ci-robot @devigned @CecileRobertMichon @nader-ziada