Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerated networking test should handle VMSS instances #1015

Closed
mboersma opened this issue Oct 29, 2020 · 7 comments · Fixed by #1242
Closed

Accelerated networking test should handle VMSS instances #1015

mboersma opened this issue Oct 29, 2020 · 7 comments · Fixed by #1242
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@mboersma
Copy link
Contributor

/kind bug

What steps did you take and what happened:

The test spec in test/e2e/azure_accelnet.go only loops over VMs in the resource group, so it's not testing the accelerated networking property of any VMSS / MachinePool clusters. It should be expanded and added to cover the VMSS spec that's now in azure_test.go.

What did you expect to happen:

e2e tests validate the accelerated networking property on VMSS instances is set as expected (true if it's available for the SKU).

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2020
@CecileRobertMichon
Copy link
Contributor

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 3, 2020
@CecileRobertMichon CecileRobertMichon added this to the next milestone Nov 12, 2020
@surajrana93
Copy link
Contributor

@mboersma @CecileRobertMichon
Do you still need help on this? Want to give it a try as a first issue

@CecileRobertMichon
Copy link
Contributor

@surajrana93 go for it. I saw you also commented on #497. Both of these are up for grabs. Make sure you comment /assign on whichever one you choose to pick up and let us know if you would like any pointers.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@CecileRobertMichon
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@jackfrancis
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants