build: lock golangci-lint to a version instead of commit sha #625
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @paulfantom. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -88,8 +88,7 @@ go_repository( | |||
| name = "com_github_golangci_golangci-lint", | |||
| build_file_generation = "on", | |||
| importpath = "github.com/golangci/golangci-lint", | |||
| strip_prefix = "golangci-lint-4570c043a9b56ccf0372cb6ba7a8b645d92b3357", | |||
| urls = ["https://github.com/golangci/golangci-lint/archive/4570c043a9b56ccf0372cb6ba7a8b645d92b3357.zip"], | |||
| tag = "v1.13", | |||
There was a problem hiding this comment.
Why v1.13 here? Any reason we shouldn't be using the latest v1.15.0 tag?
There was a problem hiding this comment.
No reason apart from the fact that this version is also used in cluster-api repo: https://github.com/kubernetes-sigs/cluster-api/blob/e9f80414db98ed2bf35f23100f0da15a601a6fc3/WORKSPACE#L38
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This is a propagation of kubernetes-sigs/cluster-api#699
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: