Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/asm_shim package should be build/asm-shim #626

Closed
randomvariable opened this issue Mar 6, 2019 · 1 comment · Fixed by #636
Closed

build/asm_shim package should be build/asm-shim #626

randomvariable opened this issue Mar 6, 2019 · 1 comment · Fixed by #636
Assignees
@detiber
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v1alpha1

Comments

@randomvariable
Copy link
Member

/kind bug

Follow up to #625
build/asm_shim needs renaming to pass linter rules.

Should be along the lines of:
Renaming asm_shim to asm-shim, and update build/go_mock.bzl to match, testing with make generate to ensure nothing else is broken.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 6, 2019
@randomvariable randomvariable mentioned this issue Mar 6, 2019
Merged
@detiber detiber added this to the v1alpha1 milestone Mar 8, 2019
@detiber
Copy link
Member

detiber commented Mar 8, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 8, 2019
@detiber detiber mentioned this issue Mar 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@detiber detiber

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging a pull request may close this issue.

Fix linting issues with asm_shim detiber/cluster-api-provider-aws
3 participants
@detiber @randomvariable @k8s-ci-robot