Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: lock golangci-lint to a version instead of commit sha #625

Merged
merged 1 commit into from
Mar 6, 2019
Merged

build: lock golangci-lint to a version instead of commit sha #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
run:
skip-files:
- build/asm_shim/c.go
detiber marked this conversation as resolved.
Show resolved Hide resolved
linters:
enable:
- golint
Expand Down
3 changes: 1 addition & 2 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ go_repository(
name = "com_github_golangci_golangci-lint",
build_file_generation = "on",
importpath = "github.com/golangci/golangci-lint",
strip_prefix = "golangci-lint-4570c043a9b56ccf0372cb6ba7a8b645d92b3357",
urls = ["https://github.com/golangci/golangci-lint/archive/4570c043a9b56ccf0372cb6ba7a8b645d92b3357.zip"],
tag = "v1.13",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why v1.13 here? Any reason we shouldn't be using the latest v1.15.0 tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason apart from the fact that this version is also used in cluster-api repo: https://github.com/kubernetes-sigs/cluster-api/blob/e9f80414db98ed2bf35f23100f0da15a601a6fc3/WORKSPACE#L38

)

go_repository(
Expand Down