e2e tests #606

akutz · 2019-02-23T01:14:25Z

What this PR does / why we need it:
This patch updates documentation, the Makefile, and creates some new programs under the hack directory in order to make e2e testing as easy as possible, both locally and as a invocation point for Prow jobs.

This is a work-in-progress, and the PR is being opened as a point of discussion and to provide an opportunity for the community to give feedback early in the process.

Blocked by:

/hold

Which issue(s) this PR fixes:
Partially-Sorta-Kinda-Phixes #272 (see Special notes)

Special notes for your reviewer:
This PR alone will not phix #272 as a period Prow job will need to be created. However, the content of this PR will be how Prow initiates the e2e testing.

Release note:

Execute unit tests with "make test", integration tests with "make integration", and end-to-end tests with "make e2e".

k8s-ci-robot · 2019-02-23T01:14:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akutz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vincepri

If they are not already assigned, you can assign the PR to them by writing /assign @vincepri in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

docs/development.md

akutz · 2019-02-25T23:05:06Z

/hold cancel

This patch deploys a new Boskos janitor as a service in the same cluster running Prow. The new service is named `boskos-janitor-aws`. Related to kubernetes-sigs/cluster-api-provider-aws#272 and kubernetes-sigs/cluster-api-provider-aws#606. /area boskos

detiber

Some minor nits.

The PR description both says that it fixes #272 and that it doesn't fully resolve #272, can you update the description?

docs/development.md

hack/e2e-aws-janitor.sh

hack/e2e-aws-resources-list.sh

hack/e2e.sh

akutz · 2019-02-26T04:56:00Z

Hi Jason,

Regarding the PR description, there will be no single PR in this repo that fixes 272 as it will take a series of PRs across this and test infra. That’s why I said it partially fixed the issue. To me it’s a problem with the fixes notation that it only applies to a single issue. How do you recommend we use that when a resolution takes more than one PR across multiple repos? That would typically be an epic, but I don’t see that you’ve got ZenHub or GH projects set up to track epics.

ashish-amarnath · 2019-02-26T05:46:45Z

Makefile

+.PHONY: integration
+integration: generate verify ## Run integraion tests
+	bazel test --define='gotags=integration' --test_output all //test/integration/...
+


Suggested change

# WARNING: DO NOT SET THE `JANITOR_ENABLED` TO 1 UNLESS YOU WISH TO TEARDOWN RESOURCES IN AWS

Hi @ashish-amarnath,

Are you suggesting the definition of a target named WARNING? If so, do you mean the text should be echoed? I am sorry, but I do not understand the proposed change.

Sorry, I missed this comment.
The suggestion was to add a comment to caution users not to change the JANITOR_ENABLED flag.

randomvariable · 2019-02-26T10:06:25Z

@akutz I think @detiber means you should remove the Fixes: #272 wording, as Github will automatically close the issue. Use Partially addresses #272 or similar so it doesn't trip Github trying to be too helpful.

This patch deploys a new Boskos janitor as a service in the same cluster running Prow. The new service is named `boskos-janitor-aws`. Related to kubernetes-sigs/cluster-api-provider-aws#272 and kubernetes-sigs/cluster-api-provider-aws#606. /area boskos

akutz · 2019-02-26T16:44:29Z

@akutz I think @detiber means you should remove the Fixes: #272 wording, as Github will automatically close the issue. Use Partially addresses #272 or similar so it doesn't trip Github trying to be too helpful.

Hi @randomvariable,

I understand what he means. I just wanted to point out that the PR template pushes people to indicates fixes, even when it's partially applicable. I'll remove it though.

randomvariable · 2019-02-26T16:55:03Z

Enjoying the terminology

akutz · 2019-02-26T18:09:32Z

/hold

akutz · 2019-02-26T18:10:26Z

hack/e2e-aws-janitor.sh

+
+# Prevent a disallowed AWS key from being used.
+if grep -iqF "$(echo "${AWS_ACCESS_KEY_ID-}" | \
+  { md5sum || md5; } | awk '{print $1}')" hack/e2e-aws-disallowed.txt; then


This patch updates documentation, the Makefile, and creates some new programs under the `hack` directory in order to make e2e testing as easy as possible, both locally and as a invocation point for Prow jobs.

vincepri · 2019-03-07T16:24:10Z

/milestone v1alpha1

detiber · 2019-03-14T16:07:30Z

closing, since #658 has merged

This patch deploys a new Boskos janitor as a service in the same cluster running Prow. The new service is named `boskos-janitor-aws`. Related to kubernetes-sigs/cluster-api-provider-aws#272 and kubernetes-sigs/cluster-api-provider-aws#606. /area boskos

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2019

k8s-ci-robot requested review from davidewatson and krousey February 23, 2019 01:14

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2019

akutz changed the title ~~Easy e2e tests~~ WiP: Easy e2e tests Feb 23, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2019

akutz changed the title ~~WiP: Easy e2e tests~~ WiP: e2e tests Feb 23, 2019

akutz mentioned this pull request Feb 23, 2019

boskos: AWS janitor not cleaning up all of the resources kubernetes/test-infra#11471

Closed

akutz force-pushed the feature/easy-e2e branch 4 times, most recently from b73a326 to 654721e Compare February 23, 2019 21:20

detiber reviewed Feb 25, 2019

View reviewed changes

docs/development.md Outdated Show resolved Hide resolved

akutz force-pushed the feature/easy-e2e branch 3 times, most recently from c46f48d to 031bc0a Compare February 25, 2019 22:41

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2019

akutz changed the title ~~WiP: e2e tests~~ e2e tests Feb 25, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2019

akutz mentioned this pull request Feb 26, 2019

boskos: Deploying a new Boskos janitor for AWS kubernetes/test-infra#11511

Closed

detiber reviewed Feb 26, 2019

View reviewed changes

docs/development.md Outdated Show resolved Hide resolved

hack/e2e-aws-janitor.sh Outdated Show resolved Hide resolved

hack/e2e-aws-resources-list.sh Outdated Show resolved Hide resolved

hack/e2e.sh Outdated Show resolved Hide resolved

ashish-amarnath reviewed Feb 26, 2019

View reviewed changes

This was referenced Feb 26, 2019

Add CAPA e2e periodic and post-submit jobs kubernetes/test-infra#11524

Closed

Periodic e2e testing #272

Closed

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019

akutz commented Feb 26, 2019

View reviewed changes

akutz force-pushed the feature/easy-e2e branch from 031bc0a to a2a4459 Compare February 26, 2019 21:54

Easy e2e tests

0cc8410

This patch updates documentation, the Makefile, and creates some new programs under the `hack` directory in order to make e2e testing as easy as possible, both locally and as a invocation point for Prow jobs.

akutz force-pushed the feature/easy-e2e branch from a2a4459 to 0cc8410 Compare February 26, 2019 21:56

This was referenced Mar 1, 2019

Remove requirement for GNU Make, envsubst & gettext for end-user experience #299

Closed

[WIP] Embed example templates into clusterawsadm #617

Closed

k8s-ci-robot added this to the v1alpha1 milestone Mar 7, 2019

randomvariable mentioned this pull request Mar 14, 2019

e2e tests, rebase of 606 #658

Merged

detiber closed this Mar 14, 2019

randomvariable mentioned this pull request Mar 14, 2019

Remove more bazel defaults #665

Merged

detiber mentioned this pull request Mar 20, 2019

boskos: Deploying a new Boskos janitor for AWS kubernetes/test-infra#11848

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e tests #606

e2e tests #606

akutz commented Feb 23, 2019 •

edited

Loading

k8s-ci-robot commented Feb 23, 2019

akutz commented Feb 25, 2019

detiber left a comment

akutz commented Feb 26, 2019

ashish-amarnath Feb 26, 2019 •

edited

Loading

akutz Feb 26, 2019

ashish-amarnath Mar 5, 2019

randomvariable commented Feb 26, 2019

akutz commented Feb 26, 2019

randomvariable commented Feb 26, 2019

akutz commented Feb 26, 2019

akutz Feb 26, 2019

vincepri commented Mar 7, 2019

detiber commented Mar 14, 2019


	# WARNING: DO NOT SET THE `JANITOR_ENABLED` TO 1 UNLESS YOU WISH TO TEARDOWN RESOURCES IN AWS

e2e tests #606

e2e tests #606

Conversation

akutz commented Feb 23, 2019 • edited Loading

k8s-ci-robot commented Feb 23, 2019

akutz commented Feb 25, 2019

detiber left a comment

Choose a reason for hiding this comment

akutz commented Feb 26, 2019

ashish-amarnath Feb 26, 2019 • edited Loading

Choose a reason for hiding this comment

akutz Feb 26, 2019

Choose a reason for hiding this comment

ashish-amarnath Mar 5, 2019

Choose a reason for hiding this comment

randomvariable commented Feb 26, 2019

akutz commented Feb 26, 2019

randomvariable commented Feb 26, 2019

akutz commented Feb 26, 2019

akutz Feb 26, 2019

Choose a reason for hiding this comment

vincepri commented Mar 7, 2019

detiber commented Mar 14, 2019

akutz commented Feb 23, 2019 •

edited

Loading

ashish-amarnath Feb 26, 2019 •

edited

Loading