Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests, rebase of 606 #658

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

randomvariable
Copy link
Member

What this PR does / why we need it:
Is a rebase of #606.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Addresses #272

/milestone v1alpha1

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


akutz and others added 2 commits March 14, 2019 00:36
This patch updates documentation, the Makefile, and creates some new
programs under the `hack` directory in order to make e2e testing as easy
as possible, both locally and as a invocation point for Prow jobs.
@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2019
@randomvariable
Copy link
Member Author

Think this is good to go, and restores e2e back to a working state.

Any additional changes for janitor, and to get periodics working on Prow can be addressed in follow up PRs.

@detiber
Copy link
Member

detiber commented Mar 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 92bda1a into kubernetes-sigs:master Mar 14, 2019
@detiber detiber mentioned this pull request Mar 14, 2019
@randomvariable randomvariable deleted the e2e-tests-redux branch March 14, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants