Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-janitor: Support for CloudFormation Stacks #11504

Merged
merged 1 commit into from
Feb 26, 2019
Merged

aws-janitor: Support for CloudFormation Stacks #11504

merged 1 commit into from
Feb 26, 2019

Conversation

akutz
Copy link
Member

@akutz akutz commented Feb 25, 2019

This patch introduces support for the removal of CloudFormation stacks by the AWS janitor.

/assign @detiber @krzyzacy
/cc @randomvariable @vincepri

@akutz
aws-janitor: Support for CloudFormation Stacks
7398429 
This patch introduces support for the removal of CloudFormation stacks
by the AWS janitor.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2019
@akutz
Copy link
Member Author

akutz commented Feb 25, 2019

/test pull-test-infra-verify-deps

@akutz akutz mentioned this pull request Feb 25, 2019
Closed
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a4dc227cf859c73ab94ce182e60c7d19fca91f1

vincepri
vincepri reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, thanks for working on this!

maintenance/aws-janitor/resources/cloud_formation_stacks.go
func (p cloudFormationStack) delete(svc *cf.CloudFormation) error {
input := &cf.DeleteStackInput{StackName: aws.String(p.name)}
if _, err := svc.DeleteStack(input); err != nil {
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for the stack to be deleted?

Copy link
Member Author

@akutz akutz Feb 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincepri,

I'd just as soon not get hung up on waiting for things at this point. There are enough existing race conditions that I was already going to update the Boskos janitor to do three sweeps with a pause in between each one.

A separate PR at a later date will work out ordering, waiting, and dependency graphs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincepri,

FWIW, this is the change to the Boskos AWS janitor that performs, by default, three sweeps.

@akutz akutz mentioned this pull request Feb 26, 2019
Closed
@detiber
Copy link
Member

detiber commented Feb 26, 2019

/approve

@krzyzacy
Copy link
Member

/approve
/hold

feel free to /hold cancel

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akutz, detiber, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@akutz
Copy link
Member Author

akutz commented Feb 26, 2019

Well I’m good with it since it does work from my local tests. As @vincepri mentioned, we do need to revisit the resources list and work out a better dependency graph, but that’s phase two.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 80c84eb into kubernetes:master Feb 26, 2019
@akutz akutz mentioned this pull request Feb 26, 2019
Closed
@akutz akutz deleted the feature/aws-janitor-cf-stacks branch February 26, 2019 22:13
@jetstack-bot jetstack-bot mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri left review comments

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@detiber detiber

@krzyzacy krzyzacy

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akutz @randomvariable @k8s-ci-robot @detiber @krzyzacy @vincepri