-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release artifacts MVP #580
Release artifacts MVP #580
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Back. I'll need to rebase onto #573 |
7171e8d
to
134b87c
Compare
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work. I think I need a little more time to digest, but initial pass is done
Removes make and bazel from UX Signed-off-by: Naadir Jeewa <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]>
Co-Authored-By: randomvariable <[email protected]>
Co-Authored-By: randomvariable <[email protected]>
Signed-off-by: Naadir Jeewa <[email protected]>
8bad90e
to
f8f0d3b
Compare
Signed-off-by: Naadir Jeewa <[email protected]>
f8f0d3b
to
b50122f
Compare
Signed-off-by: Naadir Jeewa <[email protected]>
Cleaned this up a little more following @chuckha's recommendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I have one question and then will give it a day to see if anyone else has more feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
A+
No longer use a variable lookup in the rule. Signed-off-by: Naadir Jeewa <[email protected]>
/hold |
/unhold |
/hold cancel |
/lgtm |
@randomvariable: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Refactors the way manifests are generated so that provider components are generated by Bazel in line with the image.
make release-artifacts
will generate a tar file with the manifest templates, shell script and getting started guide.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #578
Fixes #569,
Related to #549, #276, #122
Special notes for your reviewer:
E2E tests were rewired to make use of the artifact creation here, so that it tests the manifests generated by the tools we provide to the user. During that, made some changes to provide more logging information during the run. Can confirm no secrets are leaked by doing this.
Release note: