Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize 2.0+ not compatible with getting started guide #569

Closed
randomvariable opened this issue Feb 12, 2019 · 5 comments · Fixed by #580
Closed

Kustomize 2.0+ not compatible with getting started guide #569

randomvariable opened this issue Feb 12, 2019 · 5 comments · Fixed by #580
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@randomvariable
Copy link
Member

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Related to #549 - alternatives to kustomize/envsubst
Related to #276 - UX improvements.

What did you expect to happen:
Due to security concerns, the use of commands as a secret generator has been removed, but the current user workflow is reliant upon it.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Workflow needs to be fixed to be compatible with Kustomize 2, ideally in a backwards compatible way.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 12, 2019
@randomvariable
Copy link
Member Author

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 12, 2019
@detiber
Copy link
Member

detiber commented Feb 13, 2019

/milestone v1alpha1
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 13, 2019
@detiber
Copy link
Member

detiber commented Feb 13, 2019

@randomvariable I don't think we need to enforce backwards compatibility. I'm good with making kustomize 2.x a requirement if we can get everything patched up to work.

@vincepri
Copy link
Member

Related to kubernetes-sigs/cluster-api#745

@randomvariable
Copy link
Member Author

Yeah, not intending to. As far as the user-facing bits, they won't notice if we're still using an older kustomize inside bazel to generate bare manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants