Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove make from end-user workflow #310

Closed
wants to merge 4 commits into from

Conversation

detiber
Copy link
Member

@detiber detiber commented Oct 24, 2018

Removes make from end-user workflow and replaces the current manifest generation steps with clusterawsadm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2018
@detiber
Copy link
Member Author

detiber commented Oct 24, 2018

Still very much WIP, mostly some moving things around currently.

Plan is to continue to extend by moving the steps performed in generate-yaml.sh into clusterawsadm as well with the output being kustomize patches rather than transforming directly into the manifests.

Once the patches are created, then we can have the user run kustomize as a separate step.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

@detiber: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-build 150ea9d link /test pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-make 150ea9d link /test pull-cluster-api-provider-aws-make
pull-cluster-api-provider-aws-bazel-build 150ea9d link /test pull-cluster-api-provider-aws-bazel-build
pull-cluster-api-provider-aws-test 150ea9d link /test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@randomvariable
Copy link
Member

Superseded by #580

/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closed this PR.

In response to this:

Superseded by #580

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@detiber detiber deleted the manifestsNoMake branch April 2, 2019 17:33
enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Apr 15, 2020
[OCPCLOUD-813] Bump scripts to Go 1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants