Cluster and machine actuator updates status #304
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
|
/ok-to-test |
|
@ashish-amarnath: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
k8s-ci-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashish-amarnath, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
||
| if rawBytes, err = yaml.Marshal(status); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
The above could be simplified a little
rawBytes, err := yaml.Marshal(status)
if err != nil {
return nil, err
}
same for the EncodeMachineStatus
There was a problem hiding this comment.
This will go away when we switch to the api machinery conversion.
I will do that as a part of this PR
There was a problem hiding this comment.
Looks like we'll need to revisit the api-machinery conversion. Will open an issue for that if this remains unsolved.
There was a problem hiding this comment.
Created #306
|
|
||
| return &runtime.RawExtension{ | ||
| Raw: rawBytes, | ||
| //Object: ??, |
There was a problem hiding this comment.
Do we need the Object part at all?
CC @detiber
There was a problem hiding this comment.
This will go away when we switch to the api machinery conversion.
I will do that as a part of this PR
There was a problem hiding this comment.
Looks like we'll need to revisit the api-machinery conversion. Will open an issue for that if this remains unsolved.
There was a problem hiding this comment.
Created #306
* add methods to encode ClusterProviderStatus and MachineProviderStatus * add methods to store cluster and machine status * store cluster and machine status in actuator function
ashish-amarnath
force-pushed
the
iss-310-update-status
branch
from
307731a to
9e4ec9f
Compare
ashish-amarnath
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
ashish-amarnath
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Remove bison from OWNERS file
What this PR does / why we need it:
Currently, updated status for cluster and machine don't get stored so the actuators work is not saved. This PR saves the status for both cluster and machine.
In this PR:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # 288
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: