Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use API machinery conversion APIs for AWSMachineProviderStatus and AWSClusterProviderStatus #306

Closed
ashish-amarnath opened this issue Oct 24, 2018 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@ashish-amarnath
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
It should be possible to use api-machinery APIs to convert the status to RawExtentions
https://godoc.org/k8s.io/apimachinery/pkg/runtime#Convert_runtime_Object_To_runtime_RawExtension

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Using this API, fails to compile like:

cannot use status (type *AWSMachineProviderStatus) as type *runtime.Object in argument to runtime.Convert_runtime_Object_To_runtime_RawExtension

and

cannot use status (type *AWSClusterProviderStatus) as type *runtime.Object in argument to runtime.Convert_runtime_Object_To_runtime_RawExtension

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2018
@detiber
Copy link
Member

detiber commented Oct 29, 2018

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 29, 2018
@timothysc
Copy link
Member

Closing, this no longer applies.

enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this issue Apr 15, 2020
[OCPCLOUD-801] Add support for Spot Instances in MachineProviderConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants