Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status doesn't get updated #288

Closed
vincepri opened this issue Oct 18, 2018 · 5 comments
Closed

Status doesn't get updated #288

vincepri opened this issue Oct 18, 2018 · 5 comments
Assignees
@ashish-amarnath
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
20181025

Comments

@vincepri
Copy link
Member

/kind bug

After the move to CRDs, we don't update the internal Status anymore, which should be updated. This issue should track possible shortcomings of the current approach and solutions.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2018
@vincepri vincepri mentioned this issue Oct 18, 2018
Merged
@detiber
Copy link
Member

detiber commented Oct 19, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 19, 2018
@detiber detiber added this to the 20181025 milestone Oct 19, 2018
@randomvariable randomvariable mentioned this issue Oct 22, 2018
Closed
3 tasks
@ashish-amarnath
Copy link
Contributor

/assign

@ashish-amarnath
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 23, 2018
@ashish-amarnath
Copy link
Contributor

ashish-amarnath commented Oct 23, 2018 •
edited
Loading

PR: #304

@detiber
Copy link
Member

detiber commented Oct 24, 2018

Closing since this should now be resolved after #304 and #307 have merged.

@detiber detiber closed this as completed Oct 24, 2018
enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this issue Feb 5, 2020
@openshift-merge-robot
Merge pull request kubernetes-sigs#288 from alexander-demichev/fix-patch
0df2d10 
Bug 1796599: Save status before Patch()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashish-amarnath ashish-amarnath

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
20181025
Development

No branches or pull requests
4 participants
@detiber @vincepri @k8s-ci-robot @ashish-amarnath