-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Umbrella] Support for EKS #1534
Comments
/priority important-longterm |
/assign @richardcase |
@richardcase I haven't followed along with the Managed proposal linked overly well, but I would expect that it should be possible to implement a Managed kubernetes provider leveraging a Control Plane provider and a MachinePool provider targeted towards EKS. See kubernetes-sigs/cluster-api-provider-azure#482 and the related discussion there. |
Thanks @detiber - i was was just reading your comments on the PR in the Azure provider. I'll follow the approach you suggest. Would you suggest that the managed control plan provider code be placed in |
@richardcase lets do |
@detiber - do you think the eks control plane should reuse the services (for example) or should it have its own specific versions? If we re-use then we would have to use the cluster scope for example and that expects a AWSCluster, which we could create with the control plane controller or we could refactor to work with multiple scopes. Either way i'm adding an eks service. |
@richardcase I think it would make sense to re-use where possible. We should probably consider refactoring common services (on an as needed basis) to remove the need for a scope to better accommodate the reuse |
@detiber - i've started to refactor the ec2 service so that networking side could be reused. Instead of removing the need for a scope i split out the networking into a network service and associated clusternetwork scope......i misread the last part of your comment about removing the need for a scope completely. Shall i change what i've done to remove the new scope and change ReconcileNetwork to accept a |
/cc |
Work is progressing on this:
A couple of questions:
@detiber - would be good to get your thoughts on the above. |
Hi @richardcase – @dthorsen & myself are taking some time over the next couple of weeks to focus on EKS. I'm curious if you think this work's in a place where we could help with it? |
@sethp-nr - its not quite in a place where collaboration would be easy. I paused work on it these last 2 days whilst i made a change to the default subnetting strategy (something i originally added for this). I also realised that some of the changes i have made are not needed so i need to undo those as there is a better way to handle it. I'll make those changes and let you know. |
Cool, no rush here – I'll plan to review #1721 when it's ready, and otherwise let me know if there's anything you think we can do on the CAPA side. One thing we stumbled into coming from the other direction (looking to join CAPA Machines to an existing EKS cluster) was that since nobody ran |
I hadn't got to the machines part yet, so thats interesting. It will be interesting how we handle an unmanaged nodes, managed nodes and also supporting fargate. |
Wanted to add some tracking details, so I will update this comment as things happen:
|
And also:
|
@rudoi - i've moved the list of items up into the description |
Given we have issues for all of these, and a lot of these are done, going to close this one as it's not useful for milestone tracking. /close |
@randomvariable: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Describe the solution you'd like
I'd like to see the ability to create/manage EKS clusters using Cluster API. This is the parent issue for implementing EKS. There are sub tasks and issues listed below for implementation of specific functionality.
Anything else you would like to add:
This comes up quite a bit in discussions with customers around capi. Especially in hybrid on-prem/cloud type environments.
This relates to kubernetes-sigs/cluster-api#980 and also the associated proposal kubernetes-sigs/cluster-api#2045
Tasks:
The text was updated successfully, but these errors were encountered: