Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Fargate profiles support #1786

Closed
richardcase opened this issue Jul 6, 2020 · 10 comments · Fixed by #2265
Closed

EKS Fargate profiles support #1786

richardcase opened this issue Jul 6, 2020 · 10 comments · Fixed by #2265
Labels
adr-required Denotes an issue or PR contains a decision that needs documenting using an ADR. area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like
When creating a EKS cluster i want the option to be able to use fargate for the workloads. Adding support for fargate profiles would be needed.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 6, 2020
@detiber detiber added this to the v0.5.x milestone Jul 13, 2020
@randomvariable randomvariable added the area/provider/eks Issues or PRs related to Amazon EKS provider label Aug 14, 2020
@randomvariable randomvariable modified the milestones: v0.5.x, v0.6.0, Next Aug 14, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2020
@richardcase
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2021
@richardcase
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2021
@michaelbeaumont
Copy link
Contributor

Mapping this to MachinePool feels like a little bit of a mismatch given that we don't have version, replicas, bootstrap, etc. We have Nodes but we don't really have spec.replicas. Do we think this is important?

@richardcase
Copy link
Member Author

/label adr-required

@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) /label adr-required cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label adr-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase richardcase added the adr-required Denotes an issue or PR contains a decision that needs documenting using an ADR. label Feb 11, 2021
@richardcase
Copy link
Member Author

Mapping this to MachinePool feels like a little bit of a mismatch given that we don't have version, replicas, bootstrap, etc. We have Nodes but we don't really have spec.replicas. Do we think this is important?

As this doesn't really match well to upstream CAPI kinds I wonder if we just create an AWSFargateProfile kind with associated controller? And maybe it just cares about its matching AWSManagedControlPlane. WDYT?

@richardcase
Copy link
Member Author

@michaelbeaumont @randomvariable - i think we should probably capture the decision on how we implement this in an ADR

@richardcase
Copy link
Member Author

/milestone v0.6.5

@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.6.5 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adr-required Denotes an issue or PR contains a decision that needs documenting using an ADR. area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants